From: Jeremiah Mahler <jmmahler@gmail.com>
To: Jonas Lundqvist <jonas@gannon.se>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: line6: remove spaces before commas.
Date: Mon, 29 Dec 2014 09:41:16 -0800 [thread overview]
Message-ID: <20141229174116.GA31402@hudson.localdomain> (raw)
In-Reply-To: <1419867258-3146-1-git-send-email-jonas@gannon.se>
Jonas,
In your subject line, when you create a new version of a patch, include
the version number. In this case it would be "[PATCH v2]".
On Mon, Dec 29, 2014 at 04:34:18PM +0100, Jonas Lundqvist wrote:
> Fixed three errors in pcm.h found by checkpatch.pl:
>
> drivers/staging/line6/pcm.h:148: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:155: ERROR: space prohibited before that ','
> (ctx:WxE)
> drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ','
> (ctx:WxE)
>
It is better than no description at all. But listing each identical
error is redundant. I would have just said something to the effect of
"fix three space prohibited errors ...".
> Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
> ---
> drivers/staging/line6/pcm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
[...]
--
- Jeremiah Mahler
prev parent reply other threads:[~2014-12-29 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 13:26 [PATCH] Staging: line6: remove spaces before commas Jonas Lundqvist
2014-12-28 15:44 ` Jeremiah Mahler
2014-12-28 20:30 ` Jonas Lundqvist
2014-12-29 7:02 ` Sudip Mukherjee
2014-12-29 15:34 ` Jonas Lundqvist
2014-12-29 17:41 ` Jeremiah Mahler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229174116.GA31402@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonas@gannon.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox