Re: Vendor Setup for walkera_dev structure argument in the function,walkera0701_connect for the file,walera0701.c

Dmitry Torokhov
2014-12-29T18:31:58Z

Hi Nick,

On Mon, Dec 29, 2014 at 12:24:14AM -0500, nick wrote:
> Greetings Dmirty,
> I am wondering about the below code in the function,walkera701_connect in the file,walera0701.c.
> /* TODO what id vendor/product/version ? */
> w->input_dev->id.vendor = 0x0001;
> w->input_dev->id.product = 0x0001;
> w->input_dev->id.version = 0x0100;
> As the maintainer I am wondering if you known the values these need to
> be set to as it seems a rather trivial patch for me to write if you
> can send me the correct values or a reference sheet.

I think we should not have initialized them at all as I don't think we
have good values for IDs for it. But now that we had done that, current
values are as good as any... Just leave the driver alone.

Also, as you mentioned, producing a patch is trivial. If you want to get
involved in kernel development you need to do some research and actually
_propose_ the changes (with explanation why the change is needed and why
you chose to make the change in a certain way), rather just asking
maintainers for explicit instructions on what changes to make.

Thanks.

--
Dmitry