From: Dimitri Sivanich <sivanich@sgi.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gru: cleanup on stack DECLARE_COMPLETION
Date: Mon, 29 Dec 2014 12:38:40 -0600 [thread overview]
Message-ID: <20141229183840.GA5792@sgi.com> (raw)
In-Reply-To: <1419877876-30308-1-git-send-email-der.herr@hofr.at>
Acked-by: Dimitri Sivanich <sivanich@sgi.com>
On Mon, Dec 29, 2014 at 01:31:16PM -0500, Nicholas Mc Guire wrote:
> fix-up for incorrect use of DECLARE_COMPLETION. see also commit
> 6e9a4738 ("completions: lockdep annotate on stack completions")
>
> V2: split out patch for individual files and (hopefully) proper
> labeling this time
>
> patch is against linux-next 3.19.0-rc1 -next-20141226
>
> patch was compile tested with defconfig_x86_64 + CONFIG_IRQ_REMAP=y
> CONFIG_X86_X2APIC=y, CONFIG_X86_UV=y, CONFIG_SGI_GRU=y
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> drivers/misc/sgi-gru/grukservices.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 913de07..abf2b73 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -1044,7 +1044,7 @@ done:
>
> static int quicktest2(unsigned long arg)
> {
> - static DECLARE_COMPLETION(cmp);
> + static DECLARE_COMPLETION_ONSTACK(cmp);
> unsigned long han;
> int blade_id = 0;
> int numcb = 4;
> --
> 1.7.10.4
prev parent reply other threads:[~2014-12-29 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 18:31 [PATCH v2] gru: cleanup on stack DECLARE_COMPLETION Nicholas Mc Guire
2014-12-29 18:38 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229183840.GA5792@sgi.com \
--to=sivanich@sgi.com \
--cc=der.herr@hofr.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox