From: Zidan Wang <b50113@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.de" <tiwai@suse.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"ckeepax@opensource.wolfsonmicro.com"
<ckeepax@opensource.wolfsonmicro.com>,
"Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK
Date: Tue, 30 Dec 2014 10:29:18 +0800 [thread overview]
Message-ID: <20141230022917.GA17807@b50113> (raw)
In-Reply-To: <20141229160514.GQ17800@sirena.org.uk>
On Mon, Dec 29, 2014 at 04:05:14PM +0000, Mark Brown wrote:
> On Mon, Dec 29, 2014 at 10:59:08AM +0000, Zidan Wang wrote:
> > Hi Mark,
>
> Don't top post and please fix your mailer to word wrap within paragraphs
> and avoid corrupting the mail it's quoting.
>
> > You are right. When PM is disabled, the codec will not work. But there are also some codecs enable mclk in PM, such as wm8962, cs42xx8.
> > And some codecs enable codec mclk in i2c probe(), startup() and set_bias_level(). It makes me confused.
> > Can you tell me what's the general idiom to enable mclk. Thanks.
>
> Like I said in the mail to which you replied:
>
> > > This isn't going to work if PM is disabled (which is still a valid configuration). The general idiom for this is that the driver should start up with everything powered up then let runtime idle turn things off if they're not required. That way if runtime PM is disabled then the system will still work as everything will just stay powered on all the time.
I want put mclk enable to set_bias_level. Do you thinks it make sense?
next prev parent reply other threads:[~2014-12-30 3:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 5:45 [alsa-devel][PATCH v4] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK Zidan Wang
2014-12-11 9:15 ` Charles Keepax
2014-12-22 18:10 ` Mark Brown
2014-12-29 10:59 ` Zidan Wang
2014-12-29 16:05 ` Mark Brown
2014-12-30 2:29 ` Zidan Wang [this message]
2014-12-30 16:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141230022917.GA17807@b50113 \
--to=b50113@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox