From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
gdonald@gmail.com, tapaswenipathak@gmail.com,
yejiayily@gmail.com, mcgrof@do-not-panic.com, anarey@gmail.com,
linux-kernel@vger.kernel.org, rmfrfs@gmail.com, joe@perches.com
Subject: Re: [PATCH 1/4] staging: rtl8192u: fix comments
Date: Wed, 31 Dec 2014 20:28:42 +0100 [thread overview]
Message-ID: <20141231192842.GC25819@t400> (raw)
In-Reply-To: <CAA5enKaHPBWvmQfDEkdG5T-ZMgq-qCD1arCDvUTBK4bQSmqTNg@mail.gmail.com>
On 12/31, Lorenzo Stoakes wrote:
> On 31 December 2014 at 19:00, Konrad Zapalowicz <bergo.torino@gmail.com> wrote:
> >
> > You also fix the line length here which shall be the subject of a
> > separate patch as this is not C99 comments related change.
> >
>
> Apologies - I missed this, will prepare a v2 with this separated out
> into a different patch. Relatedly, the intent was to fix whitespace
> issues rather than line length as I gather a specific line length
> limit is still a matter of debate in kernel style? I didn't want to
Usually the kernel people like the line length of 80 characters. There
are exceptions like for example for log messages because it makes easier
to search for it however most of the time 80 is good and whenever
possible it shall be applied.
You can read about it in the
https://www.kernel.org/doc/Documentation/CodingStyle document in second
chapter.
cheers,
konrad
> create additional noise by attempting to address that as well.
>
> Best, Lorenzo
next prev parent reply other threads:[~2014-12-31 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 18:42 [PATCH 1/4] staging: rtl8192u: fix comments Lorenzo Stoakes
2014-12-31 18:42 ` [PATCH 2/4] staging: rtl8192u: fix whitespace Lorenzo Stoakes
2014-12-31 18:42 ` [PATCH 3/4] staging: rtl8192u: remove redundant code Lorenzo Stoakes
2014-12-31 18:42 ` [PATCH 4/4] staging: rtl8192u: Refactor heavy nesting Lorenzo Stoakes
2014-12-31 19:00 ` [PATCH 1/4] staging: rtl8192u: fix comments Konrad Zapalowicz
2014-12-31 19:07 ` Lorenzo Stoakes
2014-12-31 19:28 ` Konrad Zapalowicz [this message]
2014-12-31 19:23 ` Jeremiah Mahler
2014-12-31 19:28 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141231192842.GC25819@t400 \
--to=bergo.torino@gmail.com \
--cc=anarey@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mcgrof@do-not-panic.com \
--cc=rmfrfs@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=yejiayily@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox