Re: 2.6.6-rc3-mm1

Andrew Morton
2004-05-02T00:57:08Z

Pasi Savolainen <psavo@iki.fi> wrote:
>
> I've also wondered a bit about slabtop, is this really OK for half-a-day
> uptime and not really changing since?:
>
> OBJS ACTIVE USE OBJ SIZE SLABS OBJ/SLAB CACHE SIZE NAME
> 348220 348135 99% 0.19K 17411 20 69644K dentry_cache
> 313138 313049 99% 0.50K 44734 7 178936K ext3_inode_cache
> 10530 7354 69% 0.05K 135 78 540K buffer_head

2.6.6-rc3-mm1 is totally broken in the slab-shrinking area (sorry).

--- 25/mm/vmscan.c~shrink_slab-handle-GFP_NOFS-fix 2004-05-01 14:34:25.446391008 -0700
+++ 25-akpm/mm/vmscan.c 2004-05-01 14:34:37.424570048 -0700
@@ -156,7 +156,7 @@ static int shrink_slab(unsigned long sca
shrinker->nr = LONG_MAX; /* It wrapped! */

if (shrinker->nr <= SHRINK_BATCH)
- break;
+ continue;
while (shrinker->nr) {
long this_scan = shrinker->nr;
int shrink_ret;

_