Re: 2.6.6-rc3-mm1

Ian Kent
2004-05-04T01:45:50Z

On Mon, 3 May 2004, Jeff Moyer wrote:

> ==> Regarding Re: 2.6.6-rc3-mm1; raven@themaw.net adds:
>
> raven> The case where two process similtaneously trigger a mount in autofs4
> raven> can cause multiple requests to the daemon for the same mount. The
> raven> daemon handles this OK but it's possible an incorrect error to be
> raven> returned. For this reason I believe it is better to change the spin
> raven> lock to a semaphore in waitq.c. This makes the second and subsequent
> raven> request wait on the q as ther supposed to.
>
> This looks good to me. Do you also need to take the semaphore in
> autofs4_catatonic_mode(), around the hijacking of the queue?
>

btw I've been back and forward on the spin lock semaphore use in waitq.c
for some time. This last review has made the decision clear. I'll be
adding it to the 2.4 patch as well.

Ian