Re: 2.6.6-rc3-mm1: modular ACPI button broken

Valdis.Kletnieks
2004-05-03T18:38:16Z

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Sat, 01 May 2004 13:44:21 +0200, Adrian Bunk said:

> This seems to be introduced by the button driver unload unload patch
> (Bugzilla #2281) included in the ACPI BK patch.
>
> It seems two EXPORT_SYMBOL's are missing in scan.c?

And a needed #include, as well (found that out the hard way). Here's
the "works for me" patch...

--- linux-2.6.6-rc3-mm1/drivers/acpi/scan.c.modules 2004-04-30 21:45:27.348492000 -0400
+++ linux-2.6.6-rc3-mm1/drivers/acpi/scan.c 2004-04-30 23:26:24.994263676 -0400
@@ -4,6 +4,7 @@

#include <linux/init.h>
#include <linux/acpi.h>
+#include <linux/module.h>

#include <acpi/acpi_drivers.h>
#include <acpi/acinterp.h> /* for acpi_ex_eisa_id_to_string() */
@@ -16,7 +17,9 @@ ACPI_MODULE_NAME ("scan")

extern struct acpi_device *acpi_root;
struct acpi_device *acpi_fixed_pwr_button;
+EXPORT_SYMBOL(acpi_fixed_pwr_button);
struct acpi_device *acpi_fixed_sleep_button;
+EXPORT_SYMBOL(acpi_fixed_sleep_button);

#define ACPI_BUS_CLASS "system_bus"

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]