From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Lorenzo Stoakes <lstoakes@gmail.com>,
gregkh@linuxfoundation.org, anarey@gmail.com,
mcgrof@do-not-panic.com, tapaswenipathak@gmail.com,
rmfrfs@gmail.com, yejiayily@gmail.com, gdonald@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace
Date: Thu, 1 Jan 2015 11:58:16 +0530 [thread overview]
Message-ID: <20150101062816.GA2710@sudip-PC> (raw)
In-Reply-To: <1420090813.6066.9.camel@perches.com>
On Wed, Dec 31, 2014 at 09:40:13PM -0800, Joe Perches wrote:
> On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote:
> > On Wed, Dec 31, 2014 at 09:33:43PM +0000, Lorenzo Stoakes wrote:
> > > This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
> > > in r8192U_dm.c and additionally it removes inconsistent whitespace
> > > throughout.
> > >
> > > Additionally some 0x00... padding has been added for alignment to the
> > > edca_setting_* variables.
> >
> > i may be wrong, but looks like you are doing many different things in the patch, not just whitespace errors.
> > marked a few, please see inline -
>
> Don't get carried away with patch type separation
> and please remember to trim your replies to just
> the areas you comment on.
sorry for not trimming that. I noticed the big size while sending, but at that time the damage has already been done.
but is it ok if we mention one thing in the commit log and do other things also? shouldn't we atleast mention that in the commit?
sorry again.
sudip
>
>
next prev parent reply other threads:[~2015-01-01 6:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 21:10 [PATCH v2 1/4] staging: rtl8192u: fix comments Lorenzo Stoakes
2014-12-31 21:10 ` [PATCH v2 2/4] staging: rtl8192u: fix whitespace Lorenzo Stoakes
2014-12-31 21:20 ` Joe Perches
2014-12-31 21:28 ` Lorenzo Stoakes
2014-12-31 21:33 ` [PATCH v3 " Lorenzo Stoakes
2015-01-01 4:47 ` Sudip Mukherjee
2015-01-01 5:40 ` Joe Perches
2015-01-01 6:28 ` Sudip Mukherjee [this message]
2015-01-01 10:06 ` Lorenzo Stoakes
2014-12-31 21:10 ` [PATCH v2 3/4] staging: rtl8192u: remove redundant code Lorenzo Stoakes
2015-01-01 4:49 ` Sudip Mukherjee
2015-01-01 4:58 ` Sudip Mukherjee
2015-01-01 10:12 ` Lorenzo Stoakes
2014-12-31 21:10 ` [PATCH v2 4/4] staging: rtl8192u: Refactor heavy nesting Lorenzo Stoakes
2015-01-10 17:58 ` [PATCH v2 1/4] staging: rtl8192u: fix comments Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150101062816.GA2710@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=anarey@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mcgrof@do-not-panic.com \
--cc=rmfrfs@gmail.com \
--cc=tapaswenipathak@gmail.com \
--cc=yejiayily@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox