From: Johan Hovold <johan@kernel.org>
To: "Peterson, David" <David.Peterson@cel.com>
Cc: "johan@kernel.org" <johan@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Additional devices added to cp210x usb-to-serial driver in kernel 3.16
Date: Fri, 2 Jan 2015 14:50:21 +0100 [thread overview]
Message-ID: <20150102135021.GA12203@localhost> (raw)
In-Reply-To: <641A0889272F104D8B07278675C0C484010B1A94@hq27>
On Mon, Dec 29, 2014 at 10:49:34PM +0000, Peterson, David wrote:
> commit 975ae8b32bc5f52a5456e42c3c3310937c6fe833
> Author: David Peterson <david.peterson@cel.com>
> Date: Mon Dec 29 15:59:37 2014 -0600
The above does not belong in the commit message (i.e. mail body).
Please read Documentation/SubmittingPatches, and consider using "git
format-patch" (and "git send-email").
> Added virtual com port VID/PID entries for CEL USB sticks and MeshWorks devices
> Signed-off-by: David Peterson <david.peterson@cel.com>
Also run scripts/checkpatch.pl on your patch before submitting, it would
have let you now that there are whitespace issues below.
Care to fix this up and resend?
Thanks,
Johan
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 6c4eb3c..a6db2fc 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -120,6 +120,9 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
> { USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */
> { USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */
> + { USB_DEVICE(0x10C4, 0x8856) }, /* CEL EM357 ZigBee USB Stick - LR */
> + { USB_DEVICE(0x10C4, 0x8857) }, /* CEL EM357 ZigBee USB Stick */
> + { USB_DEVICE(0x10C4, 0x8977) }, /* CEL MeshWorks DevKit Device */
> { USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */
> { USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */
> { USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */
parent reply other threads:[~2015-01-02 13:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <641A0889272F104D8B07278675C0C484010B1A94@hq27>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102135021.GA12203@localhost \
--to=johan@kernel.org \
--cc=David.Peterson@cel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox