Re: [RFC/PATCHSET 00/30] perf tools: New build framework

Jiri Olsa
2015-01-04T15:51:04Z

On Fri, Jan 02, 2015 at 06:36:12PM +0100, Ingo Molnar wrote:
>
> * Jiri Olsa <jolsa@kernel.org> wrote:
>
> > [...] The basic idea is the same as in kbuild system, with some
> > minor changes to allow for multiple binaries build definitions.
>
> > tools/perf/Build | 48 ++
> > tools/perf/Build.include | 75 ++++
> > tools/perf/Documentation/Build | 123 +++++
> > tools/perf/Makefile.build | 122 +++++
> > tools/perf/Makefile.perf | 566 +++---------------------
>
> > 47 files changed, 827 insertions(+), 541 deletions(-)
>
> Even the diffstat looks pretty good: only a modest line count
> increase.
>
> It would be useful to put this (and other build features - such
> as features/parallelisation support) into tools/kbuild/ though,
> so that other tooling can make easy use of it as well. For
> example tools/kvm/ (an external project) started off with an
> earlier version of the perf build system.

right, I'll put it in tools/build.. looks like the tools/lib/*
could use it, probably others as well

thanks,
jirka

>
> Sharing that would make quite a bit of sense, as tooling (and
> most user-space project) build systems are usually have pretty
> poor quality.
>
> Thanks,
>
> Ingo