Re: [PATCH 07/30] perf build: Add libperf objects building

Jiri Olsa
2015-01-08T14:46:42Z

On Thu, Jan 08, 2015 at 03:15:09PM +0900, Namhyung Kim wrote:
> On Fri, Jan 02, 2015 at 04:35:49PM +0100, Jiri Olsa wrote:
> > Move the util objects building under build framework.
> >
> > Add new libperf build object so it's separated from
> > the rest of the perf code and could be librarized.
> >
>
>
> [SNIP]
> > +$(OUTPUT)util/parse-events-flex.c: util/parse-events.l $(OUTPUT)util/parse-events-bison.c
> > + @$(call echo-cmd,bison)$(FLEX) -o $@ --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) util/parse-events.l
> ^^^^^
> s/bison/flex/ ?

yes

>
>
> > +
> > +$(OUTPUT)util/parse-events-bison.c: util/parse-events.y
> > + @$(call echo-cmd,bison)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c -p parse_events_
>
> I guess we can simply use "-o $@" here.

yes

>
>
> > +
> > +$(OUTPUT)util/pmu-flex.c: util/pmu.l $(OUTPUT)util/pmu-bison.c
> > + @$(call echo-cmd,flex)$(FLEX) -o $@ --header-file=$(OUTPUT)util/pmu-flex.h util/pmu.l
> > +
> > +$(OUTPUT)util/pmu-bison.c: util/pmu.y
> > + @$(call echo-cmd,bison)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c -p perf_pmu_
>
> Ditto.

and yes ;-)

thanks,
jirka