Re: [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

Eduardo Valentin
2015-02-25T18:29:26Z

[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]

Guenter,

On Wed, Feb 25, 2015 at 09:18:20AM -0800, Guenter Roeck wrote:
> On Wed, Feb 25, 2015 at 04:34:16PM +0100, Lukasz Majewski wrote:
> > Presented patches add support for Odroid's U3 optional CPU FAN, which uses PWM
> > subsystem for low level control.
> >
> > After successful probe it registers itself as a cooling device for thermal
> > subsystem.
> >
> > This driver also supports devices without DTS specified.
> >
> > To provide correct functionality, new properties to device tree description for
> > Exynos4412 and in particular Odroid U3 have been added.
> >
> > Those patches were tested at Exynos4412 - Odroid U3 board.
> >
> > Patches were applied on:
> > linux-soc-thermal/fixes branch (Linux v4.0-rc1)
> > SHA1: b71d399c7f2fe06b60b96155ec0b9ae167334e4a
> >
> > Kamil Debski (1):
> > ARM: dts: Add pwm-fan node to the Odroid-U3 board
> >
> > Lukasz Majewski (5):
> > Documentation: dts: Documentation entry to explain how to use PWM FAN
> > as a cooling device
> > ARM: dts: Add properties to use pwm-fan device as a cooling device in
> > Odroid U3
> > hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty
> > cycle
> > hwmon: pwm-fan: Read PWM FAN configuration from device tree
> > hwmon: pwm-fan: Code for using PWM FAN as a cooling device
> >
> > .../devicetree/bindings/hwmon/pwm-fan.txt | 25 +++-
> > arch/arm/boot/dts/exynos4.dtsi | 2 +-
> > arch/arm/boot/dts/exynos4412-odroidu3.dts | 43 ++++++
> > drivers/hwmon/pwm-fan.c | 166 +++++++++++++++++++--
> > 4 files changed, 220 insertions(+), 16 deletions(-)
> >
> For the series:
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
>
> Should I take it through hwmon ? Might make sense given the majority
> of the changes is in hwmon code.

I believe the series should go via your tree, yes. I had only minor
comments in the code added for the cooling device code, as it lacks the
unregistration call in the .remove callback.

Also, the DTS changes may generate conflicts with platform code. Lukasz
may probably ask Kukjin Kim to add them via the samsung tree.

BR,

Eduardo Valentin

>
> Thanks,
> Guenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]