From: Borislav Petkov <bp@alien8.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86,setup: Rename myisspace to isspace and move it to ctype.h
Date: Sat, 3 Jan 2015 13:05:20 +0100 [thread overview]
Message-ID: <20150103120520.GB30723@pd.tnic> (raw)
In-Reply-To: <1420269005-2290-1-git-send-email-kuleshovmail@gmail.com>
On Sat, Jan 03, 2015 at 01:10:05PM +0600, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> arch/x86/boot/cmdline.c | 19 +++++++------------
> arch/x86/boot/ctype.h | 5 +++++
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/x86/boot/cmdline.c b/arch/x86/boot/cmdline.c
> index 625d21b..bc1e25f 100644
> --- a/arch/x86/boot/cmdline.c
> +++ b/arch/x86/boot/cmdline.c
> @@ -14,11 +14,6 @@
>
> #include "boot.h"
>
> -static inline int myisspace(u8 c)
> -{
> - return c <= ' '; /* Close enough approximation */
> -}
> -
This is called myisspace on purpose so that it doesn't get confused with
the libc version. This patch is unnecessary IMO.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
prev parent reply other threads:[~2015-01-03 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 7:10 [PATCH v2] x86,setup: Rename myisspace to isspace and move it to ctype.h Alexander Kuleshov
2015-01-03 12:05 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150103120520.GB30723@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox