[PATCH 0/5] *** SUBJECT HERE ***

[PATCH 0/5] *** SUBJECT HERE ***

[jitendra kumar khasdev]

*** BLURB HERE ***

jitendra kumar khasdev (5):
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning

 drivers/staging/comedi/drivers/pcl812.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

-- 
1.9.1

[PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..24eb601 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -510,7 +510,8 @@ struct pcl812_private {
 	unsigned char dma;	/*  >0 use dma ( usedDMA channel) */
 	unsigned char range_correction;	/*  =1 we must add 1 to range number */
 	unsigned int last_ai_chanspec;
-	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
+	unsigned char mode_reg_int;	/*  there is stored INT number
+					    for some card */
 	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
 	unsigned int dmapages;
 	unsigned int hwdmasize;
-- 
1.9.1

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[Sudip Mukherjee]

On Sat, Jan 03, 2015 at 02:06:23PM +0530, jitendra kumar khasdev wrote:
> This is patch to file pcl812.c that fix up warning line
> over 80 character which is found by checkpatch tool.
> 
> Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>

what is Singed-off ??? why you are doing Signed-off manually? let git do it..

thanks
sudip

> ---
>  drivers/staging/comedi/drivers/pcl812.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index ac243ca..24eb601 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -510,7 +510,8 @@ struct pcl812_private {
>  	unsigned char dma;	/*  >0 use dma ( usedDMA channel) */
>  	unsigned char range_correction;	/*  =1 we must add 1 to range number */
>  	unsigned int last_ai_chanspec;
> -	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
> +	unsigned char mode_reg_int;	/*  there is stored INT number
> +					    for some card */
>  	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
>  	unsigned int dmapages;
>  	unsigned int hwdmasize;
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 24eb601..069af70 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -519,7 +519,9 @@ struct pcl812_private {
 	unsigned int hwdmaptr[2];	/*  HW PTR to DMA buf */
 	unsigned int dmabytestomove[2];	/*  how many bytes DMA transfer */
 	int next_dma_buf;	/*  which buffer is next to use */
-	unsigned int dma_runs_to_end;	/*  how many times we must switch DMA buffers */
+	unsigned int dma_runs_to_end;	/*  how many times we must switch
+					 *  DMA buffers
+					 */
 	unsigned int last_dma_run;	/*  how many bytes to transfer on last DMA buffer */
 	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
 	unsigned int divisor1;
-- 
1.9.1

[PATCH 3/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 069af70..aae934e7 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -522,7 +522,9 @@ struct pcl812_private {
 	unsigned int dma_runs_to_end;	/*  how many times we must switch
 					 *  DMA buffers
 					 */
-	unsigned int last_dma_run;	/*  how many bytes to transfer on last DMA buffer */
+	unsigned int last_dma_run;	/*  how many bytes to transfer on last
+					 *  DMA buffer
+					 */
 	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
 	unsigned int divisor1;
 	unsigned int divisor2;
-- 
1.9.1

[PATCH 4/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index aae934e7..5aeb695 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -525,7 +525,7 @@ struct pcl812_private {
 	unsigned int last_dma_run;	/*  how many bytes to transfer on last
 					 *  DMA buffer
 					 */
-	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
+	unsigned int max_812_ai_mode0_rangewait; /*  setling time for gain */
 	unsigned int divisor1;
 	unsigned int divisor2;
 	unsigned int use_diff:1;
-- 
1.9.1

[PATCH 5/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 5aeb695..f06347f 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1240,7 +1240,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		for (i = 0; i < 2; i++) {
 			unsigned long dmabuf;
 
-			dmabuf =  __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
+			dmabuf = __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
 			if (!dmabuf)
 				return -ENOMEM;
 
-- 
1.9.1

Re: [PATCH 0/5] *** SUBJECT HERE ***

[Greg KH]

On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote:
> *** BLURB HERE ***

What blurb?  What subject?

Re: [PATCH 0/5] *** SUBJECT HERE ***

[Paul Bolle]

On Sat, 2015-01-03 at 08:45 -0800, Greg KH wrote:
> On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote:
> > *** BLURB HERE ***
> 
> What blurb?  What subject?

jitendra used git-send-email to send this series. You'd expect
git-send-email to die with an error if the cover letter, which it should
see first, still contains these "*** [...] HERE ***" markers. What's the
reason it doesn't do that?


Paul Bolle

Re: [PATCH 0/5] *** SUBJECT HERE ***

[Konrad Zapalowicz]

On 01/03, Paul Bolle wrote:
> On Sat, 2015-01-03 at 08:45 -0800, Greg KH wrote:
> > On Sat, Jan 03, 2015 at 02:06:22PM +0530, jitendra kumar khasdev wrote:
> > > *** BLURB HERE ***
> > 
> > What blurb?  What subject?
> 
> jitendra used git-send-email to send this series. You'd expect
> git-send-email to die with an error if the cover letter, which it should
> see first, still contains these "*** [...] HERE ***" markers. What's the
> reason it doesn't do that?

git send-email does one thing and one thing only - sends stuff via
email. I do not see why it should parse the emails and decide whether to
complete the operation or break based on what is in the emails. It could
warn though however since the cover letter is a product of different
command introducing this logic would tightly couple those which is not
good.

I guess that it is better that people who send stuff acctually care what
they are sending. I mean that pretty quickly you learn to send the
series of patches first to yourself and review before it goes out to the
public.
 
> 
> Paul Bolle
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/5] *** SUBJECT HERE ***

[Paul Bolle]

On Sun, 2015-01-04 at 02:41 +0100, Konrad Zapalowicz wrote:
> git send-email does one thing and one thing only - sends stuff via
> email. I do not see why it should parse the emails and decide whether to
> complete the operation or break based on what is in the emails.

It already has to parse the file(s) it's provided with. Perhaps it
already has checks to validate Subject: lines. Would an extra test be a
burden?

> It could
> warn though however since the cover letter is a product of different
> command introducing this logic would tightly couple those which is not
> good.

A warning would be too late: the message with the silly subject would be
already sent out.

> I guess that it is better that people who send stuff acctually care what
> they are sending. I mean that pretty quickly you learn to send the
> series of patches first to yourself and review before it goes out to the
> public.

It's good if people are careful. It's also good if programs help to
avoid silly mistakes.


Paul Bolle

[PATCH 0/5] *** SUBJECT HERE ***

[Cristian Sicilia]

Some source refactoring, parameters aligment and camel case clearing.

Replacement of bool to bitfield in a struct, but not found
the population to check if it is done correctly.

Cristian Sicilia (5):
  staging: iio: adc: Tab alignment
  staging: iio: adc: Converted bool to bitfield format
  staging: iio: adc: Avoid precedence issues in macro
  staging: iio: adc: Adding temp var to improve readability
  staging: iio: adc: Remove CamelCase notation

 drivers/staging/iio/adc/ad7192.h  |  16 +++---
 drivers/staging/iio/adc/ad7280a.c | 109 ++++++++++++++++++--------------------
 2 files changed, 60 insertions(+), 65 deletions(-)

-- 
2.7.4

Re: [PATCH 0/5] *** SUBJECT HERE ***

[Matt Ranostay]

You may want to change "*** SUBJECT HERE ***"  in the future :)

- Matt

On Sat, Mar 23, 2019 at 5:53 AM Cristian Sicilia
<sicilia.cristian@gmail.com> wrote:
>
> Some source refactoring, parameters aligment and camel case clearing.
>
> Replacement of bool to bitfield in a struct, but not found
> the population to check if it is done correctly.
>
> Cristian Sicilia (5):
>   staging: iio: adc: Tab alignment
>   staging: iio: adc: Converted bool to bitfield format
>   staging: iio: adc: Avoid precedence issues in macro
>   staging: iio: adc: Adding temp var to improve readability
>   staging: iio: adc: Remove CamelCase notation
>
>  drivers/staging/iio/adc/ad7192.h  |  16 +++---
>  drivers/staging/iio/adc/ad7280a.c | 109 ++++++++++++++++++--------------------
>  2 files changed, 60 insertions(+), 65 deletions(-)
>
> --
> 2.7.4
>