From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbbADS1H (ORCPT ); Sun, 4 Jan 2015 13:27:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39123 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbbADS1F (ORCPT ); Sun, 4 Jan 2015 13:27:05 -0500 Date: Sun, 4 Jan 2015 19:26:56 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , LKML , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH 5/5] perf diff: Fix -o/--order option behavior Message-ID: <20150104182656.GC29388@krava.brq.redhat.com> References: <1419656793-32756-1-git-send-email-namhyung@kernel.org> <1419656793-32756-5-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1419656793-32756-5-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 27, 2014 at 02:06:33PM +0900, Namhyung Kim wrote: SNIP > + return 0; > + > + fmt = zalloc(sizeof(*fmt)); > + if (fmt == NULL) { > + pr_err("Memory allocation failed\n"); > + return -1; > + } > + > + fmt->cmp = hist_entry__cmp_nop; > + fmt->collapse = hist_entry__cmp_nop; > + > + switch (compute) { > + case COMPUTE_DELTA: > + fmt->sort = hist_entry__cmp_delta_idx; > + break; > + case COMPUTE_RATIO: > + fmt->sort = hist_entry__cmp_ratio_idx; > + break; > + case COMPUTE_WEIGHTED_DIFF: > + fmt->sort = hist_entry__cmp_wdiff_idx; > + break; > + default: > + BUG_ON(1); > + } > + > + list_add(&fmt->sort_list, &perf_hpp__sort_list); > + return 0; so the first 'fmt' which gets to sorting is the one for data__files[sort_idx] file, that sounds good.. but as the sorting goes through all the perf_hpp__sort_list list, it will hit the 'sort_idx' data again.. should you disable sort function for its 'fmt' then? jirka