public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: Piotr Kubus <p.t.kubus@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	abbotti@mev.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue
Date: Sun, 4 Jan 2015 23:31:29 +0100	[thread overview]
Message-ID: <20150104223129.GF25819@t400> (raw)
In-Reply-To: <1420384955-27336-1-git-send-email-p.t.kubus@gmail.com>

On 01/04, Piotr Kubus wrote:
> This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.

Nice however improve your commit message. The rule is that the lines
should wrap at 72nd column except for quoted material such as compiler
output, etc...

The 72-character columns are important for allowing quoting and they
play nicely with standard indentation from git log.

Thanks,
Konrad

> Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com>
> ---
>  drivers/staging/comedi/drivers/dmm32at.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..31919b8 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>  	/* enable the ai conversion interrupt and the clock to start scans */
>  	outb(DMM32AT_INTCLK_ADINT |
>  	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +	     dev->iobase + DMM32AT_INTCLK_REG);
>  }
>  
>  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> -- 
> 1.9.1
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2015-01-04 22:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 15:22 [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue Piotr Kubus
2015-01-04 22:31 ` Konrad Zapalowicz [this message]
2015-01-05 19:24   ` Piotr Kubus
2015-01-06  6:02     ` Sudip Mukherjee
2015-01-06 10:08       ` Ian Abbott
2015-01-06 10:27         ` Sudip Mukherjee
2015-01-06 13:33           ` Konrad Zapalowicz
2015-01-06 13:50             ` Sudip Mukherjee
2015-01-06 10:06     ` Dan Carpenter
2015-01-10  0:59 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150104223129.GF25819@t400 \
    --to=bergo.torino@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.t.kubus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox