[PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Piotr Kubus]

This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.

Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com>
---
 drivers/staging/comedi/drivers/dmm32at.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
index 6df298a..31919b8 100644
--- a/drivers/staging/comedi/drivers/dmm32at.c
+++ b/drivers/staging/comedi/drivers/dmm32at.c
@@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
 	/* enable the ai conversion interrupt and the clock to start scans */
 	outb(DMM32AT_INTCLK_ADINT |
 	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
-             dev->iobase + DMM32AT_INTCLK_REG);
+	     dev->iobase + DMM32AT_INTCLK_REG);
 }
 
 static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
-- 
1.9.1

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Konrad Zapalowicz]

On 01/04, Piotr Kubus wrote:
> This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.

Nice however improve your commit message. The rule is that the lines
should wrap at 72nd column except for quoted material such as compiler
output, etc...

The 72-character columns are important for allowing quoting and they
play nicely with standard indentation from git log.

Thanks,
Konrad

> Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com>
> ---
>  drivers/staging/comedi/drivers/dmm32at.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..31919b8 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>  	/* enable the ai conversion interrupt and the clock to start scans */
>  	outb(DMM32AT_INTCLK_ADINT |
>  	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +	     dev->iobase + DMM32AT_INTCLK_REG);
>  }
>  
>  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> -- 
> 1.9.1
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Piotr Kubus]

On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
> On 01/04, Piotr Kubus wrote:
> > This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
> 
> Nice however improve your commit message. The rule is that the lines
> should wrap at 72nd column except for quoted material such as compiler
> output, etc...
> 
> The 72-character columns are important for allowing quoting and they
> play nicely with standard indentation from git log.

Hey,

I couldn't find that rule in Kernel documentation. Besides there were no
complaints from checkpatch.pl tool.

Do you mean I should resend it or wait for reply from maintainer first?

Regards,
Piotr

> 
> Thanks,
> Konrad
> 
> > Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com>
> > ---
> >  drivers/staging/comedi/drivers/dmm32at.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> > index 6df298a..31919b8 100644
> > --- a/drivers/staging/comedi/drivers/dmm32at.c
> > +++ b/drivers/staging/comedi/drivers/dmm32at.c
> > @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
> >  	/* enable the ai conversion interrupt and the clock to start scans */
> >  	outb(DMM32AT_INTCLK_ADINT |
> >  	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> > -             dev->iobase + DMM32AT_INTCLK_REG);
> > +	     dev->iobase + DMM32AT_INTCLK_REG);
> >  }
> >  
> >  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> > -- 
> > 1.9.1
> > 
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Sudip Mukherjee]

On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
> On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
> > On 01/04, Piotr Kubus wrote:
> > > This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
> > 
> > Nice however improve your commit message. The rule is that the lines
> > should wrap at 72nd column except for quoted material such as compiler
> > output, etc...
> > 
> > The 72-character columns are important for allowing quoting and they
> > play nicely with standard indentation from git log.
> 
> Hey,
> 
> I couldn't find that rule in Kernel documentation. Besides there were no
> complaints from checkpatch.pl tool.

Please check SubmittingPatches in Documentation. It says:
'the "summary" must be no more than 70-75 characters'


thanks
sudip

> Piotr
> 
> > 
> > Thanks,
> > Konrad
> > 
<snip>
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Ian Abbott]

On 06/01/15 06:02, Sudip Mukherjee wrote:
> On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
>> On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
>>> On 01/04, Piotr Kubus wrote:
>>>> This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
>>>
>>> Nice however improve your commit message. The rule is that the lines
>>> should wrap at 72nd column except for quoted material such as compiler
>>> output, etc...
>>>
>>> The 72-character columns are important for allowing quoting and they
>>> play nicely with standard indentation from git log.
>>
>> Hey,
>>
>> I couldn't find that rule in Kernel documentation. Besides there were no
>> complaints from checkpatch.pl tool.
>
> Please check SubmittingPatches in Documentation. It says:
> 'the "summary" must be no more than 70-75 characters'

In this case, it's not the "summary" that's at issue, it's the body of 
the commit message, as Konrad mentioned above.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Sudip Mukherjee]

On Tue, Jan 06, 2015 at 10:08:37AM +0000, Ian Abbott wrote:
> On 06/01/15 06:02, Sudip Mukherjee wrote:
> >On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
> >>On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
> >>>On 01/04, Piotr Kubus wrote:
> >>>>This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
> >>>
> >>>Nice however improve your commit message. The rule is that the lines
> >>>should wrap at 72nd column except for quoted material such as compiler
> >>>output, etc...
> >>>
> >>>The 72-character columns are important for allowing quoting and they
> >>>play nicely with standard indentation from git log.
> >>
> >>Hey,
> >>
> >>I couldn't find that rule in Kernel documentation. Besides there were no
> >>complaints from checkpatch.pl tool.
> >
> >Please check SubmittingPatches in Documentation. It says:
> >'the "summary" must be no more than 70-75 characters'
> 
> In this case, it's not the "summary" that's at issue, it's the body
> of the commit message, as Konrad mentioned above.

yes, i read the SubmittingPatches again. summary is the subject line. But then as Piotr Kubus has written that he could not find this rule in the documentaion, I also tried to find that in SubmittingPatches file and also in the Posting file of the development-process folder, but could not find it. Is it mentioned in some other file we missed ?

sudip
> 
> -- 
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Konrad Zapalowicz]

On 01/06, Sudip Mukherjee wrote:
> On Tue, Jan 06, 2015 at 10:08:37AM +0000, Ian Abbott wrote:
> > On 06/01/15 06:02, Sudip Mukherjee wrote:
> > >On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
> > >>On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
> > >>>On 01/04, Piotr Kubus wrote:
> > >>>>This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
> > >>>
> > >>>Nice however improve your commit message. The rule is that the lines
> > >>>should wrap at 72nd column except for quoted material such as compiler
> > >>>output, etc...
> > >>>
> > >>>The 72-character columns are important for allowing quoting and they
> > >>>play nicely with standard indentation from git log.
> > >>
> > >>Hey,
> > >>
> > >>I couldn't find that rule in Kernel documentation. Besides there were no
> > >>complaints from checkpatch.pl tool.
> > >
> > >Please check SubmittingPatches in Documentation. It says:
> > >'the "summary" must be no more than 70-75 characters'
> > 
> > In this case, it's not the "summary" that's at issue, it's the body
> > of the commit message, as Konrad mentioned above.
> 
> yes, i read the SubmittingPatches again. summary is the subject line. But then as Piotr Kubus has written that he could not find this rule in the documentaion, I also tried to find that in SubmittingPatches file and also in the Posting file of the development-process folder, but could not find it. Is it mentioned in some other file we missed ?

Then it is an 'unwritten rule' :) You can observe it just be browsing
the git log commit messages - pick a few random and you will see.

Moreover in the http://git-scm.com/book/ch5-2.html the 72-character
columns are the example of the good commit message plus Linus says so:

	"we use 72-character columns for word-wrapping, except for quoted
	material that has a specific line format."

in one of his comments
https://github.com/torvalds/linux/pull/17#issuecomment-5661185

cheers,
konrad

> sudip
> > 
> > -- 
> > -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> > -=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Sudip Mukherjee]

On Tue, Jan 06, 2015 at 02:33:27PM +0100, Konrad Zapalowicz wrote:
> On 01/06, Sudip Mukherjee wrote:
> > yes, i read the SubmittingPatches again. summary is the subject line. But then as Piotr Kubus has written that he could not find this rule in the documentaion, I also tried to find that in SubmittingPatches file and also in the Posting file of the development-process folder, but could not find it. Is it mentioned in some other file we missed ?
> 
> Then it is an 'unwritten rule' :) You can observe it just be browsing
> the git log commit messages - pick a few random and you will see.
i don't need to veify it, I don't doubt the rule. if you see all the patches i have sent, i have always maintained a rule of 70.
just curious why this 72 ..
this one gives a reason why -

http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html 

sudip

> 
> Moreover in the http://git-scm.com/book/ch5-2.html the 72-character
> columns are the example of the good commit message plus Linus says so:
> 
> 	"we use 72-character columns for word-wrapping, except for quoted
> 	material that has a specific line format."
> 
> in one of his comments
> https://github.com/torvalds/linux/pull/17#issuecomment-5661185
> 
> cheers,
> konrad
> 
> > sudip
> > > 
> > > -- 
> > > -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
> > > -=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Dan Carpenter]

On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
> Do you mean I should resend it or wait for reply from maintainer first?
> 

Resend, please.

regards,
dan carpenter

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

[Greg KH]

On Sun, Jan 04, 2015 at 04:22:35PM +0100, Piotr Kubus wrote:
> This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
> 
> Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com>
> ---
>  drivers/staging/comedi/drivers/dmm32at.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..31919b8 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>  	/* enable the ai conversion interrupt and the clock to start scans */
>  	outb(DMM32AT_INTCLK_ADINT |
>  	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +	     dev->iobase + DMM32AT_INTCLK_REG);
>  }
>  
>  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> -- 
> 1.9.1

Someone already submitted this same change before you :(