[PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..24eb601 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -510,7 +510,8 @@ struct pcl812_private {
 	unsigned char dma;	/*  >0 use dma ( usedDMA channel) */
 	unsigned char range_correction;	/*  =1 we must add 1 to range number */
 	unsigned int last_ai_chanspec;
-	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
+	unsigned char mode_reg_int;	/*  there is stored INT number
+					    for some card */
 	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
 	unsigned int dmapages;
 	unsigned int hwdmasize;
-- 
1.9.1

[PATCH 2/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 24eb601..069af70 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -519,7 +519,9 @@ struct pcl812_private {
 	unsigned int hwdmaptr[2];	/*  HW PTR to DMA buf */
 	unsigned int dmabytestomove[2];	/*  how many bytes DMA transfer */
 	int next_dma_buf;	/*  which buffer is next to use */
-	unsigned int dma_runs_to_end;	/*  how many times we must switch DMA buffers */
+	unsigned int dma_runs_to_end;	/*  how many times we must switch
+					 *  DMA buffers
+					 */
 	unsigned int last_dma_run;	/*  how many bytes to transfer on last DMA buffer */
 	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
 	unsigned int divisor1;
-- 
1.9.1

[PATCH 3/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 069af70..aae934e7 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -522,7 +522,9 @@ struct pcl812_private {
 	unsigned int dma_runs_to_end;	/*  how many times we must switch
 					 *  DMA buffers
 					 */
-	unsigned int last_dma_run;	/*  how many bytes to transfer on last DMA buffer */
+	unsigned int last_dma_run;	/*  how many bytes to transfer on last
+					 *  DMA buffer
+					 */
 	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
 	unsigned int divisor1;
 	unsigned int divisor2;
-- 
1.9.1

[PATCH 4/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index aae934e7..5aeb695 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -525,7 +525,7 @@ struct pcl812_private {
 	unsigned int last_dma_run;	/*  how many bytes to transfer on last
 					 *  DMA buffer
 					 */
-	unsigned int max_812_ai_mode0_rangewait;	/*  setling time for gain */
+	unsigned int max_812_ai_mode0_rangewait; /*  setling time for gain */
 	unsigned int divisor1;
 	unsigned int divisor2;
 	unsigned int use_diff:1;
-- 
1.9.1

[PATCH 5/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 5aeb695..f06347f 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1240,7 +1240,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		for (i = 0; i < 2; i++) {
 			unsigned long dmabuf;
 
-			dmabuf =  __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
+			dmabuf = __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
 			if (!dmabuf)
 				return -ENOMEM;
 
-- 
1.9.1

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[Sudip Mukherjee]

On Sat, Jan 03, 2015 at 06:16:31PM +0530, jitendra kumar khasdev wrote:
> This is patch to file pcl812.c that fix up warning line
> over 80 character which is found by checkpatch tool.
> 
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>

I am assuming this one you wanted to make as v3.
but why you are sending different patches to do the same type of change in comedi?

usually we send different patches to do different types of change, but for the same type of change it can be a single patch.

sudip

> ---
>  drivers/staging/comedi/drivers/pcl812.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index ac243ca..24eb601 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -510,7 +510,8 @@ struct pcl812_private {
>  	unsigned char dma;	/*  >0 use dma ( usedDMA channel) */
>  	unsigned char range_correction;	/*  =1 we must add 1 to range number */
>  	unsigned int last_ai_chanspec;
> -	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
> +	unsigned char mode_reg_int;	/*  there is stored INT number
> +					    for some card */
>  	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
>  	unsigned int dmapages;
>  	unsigned int hwdmasize;
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[Greg KH]

On Sat, Jan 03, 2015 at 06:16:31PM +0530, jitendra kumar khasdev wrote:
> This is patch to file pcl812.c that fix up warning line
> over 80 character which is found by checkpatch tool.
> 
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> ---
>  drivers/staging/comedi/drivers/pcl812.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

There are 5 patches here all with the identical subject line, which I
can't accept for the obvious reason that they must be all doing the same
exact thing, which would be pointless, right?  :)

thanks,

greg k-h

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 876 bytes --]

Hello,
Will I have to resubmit by combining all 5 into 1 patch? Please give me 
suggestion  so that I can do it in correct way.

Regards,
Jitendra


Regards,
Jitendra Kumar Khasdev,
CSE-Student | GGITM
jkhasdev@gmail.com| Mo.8435260882

On Sun, 4 Jan 2015, Greg KH wrote:

> On Sat, Jan 03, 2015 at 06:16:31PM +0530, jitendra kumar khasdev wrote:
> > This is patch to file pcl812.c that fix up warning line
> > over 80 character which is found by checkpatch tool.
> > 
> > Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
> > ---
> >  drivers/staging/comedi/drivers/pcl812.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> There are 5 patches here all with the identical subject line, which I
> can't accept for the obvious reason that they must be all doing the same
> exact thing, which would be pointless, right?  :)
> 
> thanks,
> 
> greg k-h
> 

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[Greg KH]

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Mon, Jan 05, 2015 at 09:34:57AM +0530, jitendra kumar khasdev wrote:
> Hello,
> Will I have to resubmit by combining all 5 into 1 patch? Please give me 
> suggestion  so that I can do it in correct way.

I don't know, I didn't read the patches, but if you do send a series of
patches, they each have to be doing something different to make them
different patches, right?

thanks,

greg k-h

[PATCH 0/5] *** SUBJECT HERE ***

[jitendra kumar khasdev]

*** BLURB HERE ***

jitendra kumar khasdev (5):
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning
  Staging: comedi: fix line over 80 characters warning

 drivers/staging/comedi/drivers/pcl812.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

-- 
1.9.1

[PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[jitendra kumar khasdev]

This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.

Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
---
 drivers/staging/comedi/drivers/pcl812.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..24eb601 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -510,7 +510,8 @@ struct pcl812_private {
 	unsigned char dma;	/*  >0 use dma ( usedDMA channel) */
 	unsigned char range_correction;	/*  =1 we must add 1 to range number */
 	unsigned int last_ai_chanspec;
-	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
+	unsigned char mode_reg_int;	/*  there is stored INT number
+					    for some card */
 	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
 	unsigned int dmapages;
 	unsigned int hwdmasize;
-- 
1.9.1

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

[Sudip Mukherjee]

On Sat, Jan 03, 2015 at 02:06:23PM +0530, jitendra kumar khasdev wrote:
> This is patch to file pcl812.c that fix up warning line
> over 80 character which is found by checkpatch tool.
> 
> Singed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>

what is Singed-off ??? why you are doing Signed-off manually? let git do it..

thanks
sudip

> ---
>  drivers/staging/comedi/drivers/pcl812.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index ac243ca..24eb601 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -510,7 +510,8 @@ struct pcl812_private {
>  	unsigned char dma;	/*  >0 use dma ( usedDMA channel) */
>  	unsigned char range_correction;	/*  =1 we must add 1 to range number */
>  	unsigned int last_ai_chanspec;
> -	unsigned char mode_reg_int;	/*  there is stored INT number for some card */
> +	unsigned char mode_reg_int;	/*  there is stored INT number
> +					    for some card */
>  	unsigned int ai_poll_ptr;	/*  how many sampes transfer poll */
>  	unsigned int dmapages;
>  	unsigned int hwdmasize;
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/