From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbbAEJAH (ORCPT ); Mon, 5 Jan 2015 04:00:07 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:39758 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbbAEJAE (ORCPT ); Mon, 5 Jan 2015 04:00:04 -0500 Date: Mon, 5 Jan 2015 09:59:48 +0100 From: Martin Schwidefsky To: Chen Gang Cc: Heiko Carstens , linux390@de.ibm.com, holzheu@linux.vnet.ibm.com, linux-s390@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] s390: include: timex: Use macro CLOCK_STORE_SIZE instead of hard code number Message-ID: <20150105095948.0612e7bc@mschwide> In-Reply-To: <54A76584.6020700@sunrus.com.cn> References: <54A55954.6000002@sunrus.com.cn> <20150102094625.GA4059@osiris> <54A76584.6020700@sunrus.com.cn> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15010508-0029-0000-0000-0000028844FA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 03 Jan 2015 11:44:04 +0800 Chen Gang wrote: > > Thank you for your work. > > In honest, originally, I was not sure whether it would cause bug (do not > know gcc would generic incorrect code for it). :-) Even if the code happened to be correct it does not matter. The intention of the sizeof() has been to get to the correct 16, not 8. The fix is fine as it is. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.