From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753716AbbAEKPw (ORCPT ); Mon, 5 Jan 2015 05:15:52 -0500 Received: from mail.skyhub.de ([78.46.96.112]:33580 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753326AbbAEKPu (ORCPT ); Mon, 5 Jan 2015 05:15:50 -0500 Date: Mon, 5 Jan 2015 11:15:46 +0100 From: Borislav Petkov To: punnaiah choudary kalluri Cc: Punnaiah Choudary Kalluri , dougthompson@xmission.com, "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , linux-edac@vger.kernel.org, "michal.simek@xilinx.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Rob Landley , Punnaiah Choudary Subject: Re: [PATCH v7] edac: synps: Added EDAC support for zynq ddr ecc controller Message-ID: <20150105101546.GA19655@pd.tnic> References: <20150102105008.GA31364@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 03, 2015 at 08:01:29AM +0530, punnaiah choudary kalluri wrote: > p is pointing to the stack memory. So you could go and allocate all that memory at driver init time and reuse it each time you handle an error instead of on the stack. This way your error handling paths are lean and fast. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --