From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753604AbbAEM3I (ORCPT ); Mon, 5 Jan 2015 07:29:08 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51890 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbbAEM3B (ORCPT ); Mon, 5 Jan 2015 07:29:01 -0500 Date: Mon, 5 Jan 2015 13:28:49 +0100 From: Sascha Hauer To: Matthias Brugger Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] ARM: mediatek: dts: Add uart to Aquaris5 Message-ID: <20150105122849.GF4544@pengutronix.de> References: <1420224485-11043-1-git-send-email-matthias.bgg@gmail.com> <1420224485-11043-3-git-send-email-matthias.bgg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1420224485-11043-3-git-send-email-matthias.bgg@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 13:23:07 up 81 days, 23:36, 114 users, load average: 0.12, 0.06, 0.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On Fri, Jan 02, 2015 at 07:48:05PM +0100, Matthias Brugger wrote: > This patch enables uart port for the Aquaris5 mobile phone. > > Signed-off-by: Matthias Brugger > --- > arch/arm/boot/dts/mt6589-aquaris5.dts | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/mt6589-aquaris5.dts b/arch/arm/boot/dts/mt6589-aquaris5.dts > index 0da0470..d5cbfda 100644 > --- a/arch/arm/boot/dts/mt6589-aquaris5.dts > +++ b/arch/arm/boot/dts/mt6589-aquaris5.dts > @@ -21,10 +21,16 @@ > compatible = "mundoreader,bq-aquaris5", "mediatek,mt6589"; > > chosen { > - bootargs = "earlyprintk"; > + bootargs = "console=ttyS0,921600n8 earlyprintk"; > }; stdout-path = &uart0; Should work aswell and makes you independent from the way the kernel decides to number the UARTs. > > memory { > reg = <0x80000000 0x40000000>; > }; > + > + soc { > + uart0: serial@11006000 { > + status = "okay"; > + }; > + }; By using the & notation you don't have to resemble the tree structure in the board file, like this: &uart0 { status = "okay"; }; See for example the omap, i.MX or other dts files. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |