From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390: Remove unnecessary KERN_CONT
Date: Mon, 5 Jan 2015 14:21:33 +0100 [thread overview]
Message-ID: <20150105132133.GB4281@osiris> (raw)
In-Reply-To: <1420460958.2652.4.camel@perches.com>
On Mon, Jan 05, 2015 at 04:29:18AM -0800, Joe Perches wrote:
> This has no effect as KERN_CONT is an empty string,
>
> It's probably just a missing conversion artifact as the
> other pr_cont uses in the same file don't have this prefix.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/s390/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
> index 811937b..232c14e 100644
> --- a/arch/s390/mm/fault.c
> +++ b/arch/s390/mm/fault.c
> @@ -171,7 +171,7 @@ static void dump_pagetable(unsigned long asce, unsigned long address)
> table = table + ((address >> 20) & 0x7ff);
> if (bad_address(table))
> goto bad;
> - pr_cont(KERN_CONT "S:%016lx ", *table);
> + pr_cont("S:%016lx ", *table);
Applied, thanks.
prev parent reply other threads:[~2015-01-05 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 12:29 [PATCH] s390: Remove unnecessary KERN_CONT Joe Perches
2015-01-05 13:21 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105132133.GB4281@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox