From: Andrew Lunn <andrew@lunn.ch>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arch: arm: mm: cache-feroceon-l2: Remove some unused functions
Date: Mon, 5 Jan 2015 15:32:47 +0100 [thread overview]
Message-ID: <20150105143247.GD9142@lunn.ch> (raw)
In-Reply-To: <1420134969-1892-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Thu, Jan 01, 2015 at 06:56:09PM +0100, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> l2_inv_pa() l2_clean_pa()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Please could you submit this to Russell Kings patch tracker.
Thanks
Andrew
> ---
> arch/arm/mm/cache-feroceon-l2.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mm/cache-feroceon-l2.c b/arch/arm/mm/cache-feroceon-l2.c
> index e028a7f..c2eac97 100644
> --- a/arch/arm/mm/cache-feroceon-l2.c
> +++ b/arch/arm/mm/cache-feroceon-l2.c
> @@ -65,11 +65,6 @@ static inline void l2_put_va(unsigned long vaddr)
> #endif
> }
>
> -static inline void l2_clean_pa(unsigned long addr)
> -{
> - __asm__("mcr p15, 1, %0, c15, c9, 3" : : "r" (addr));
> -}
> -
> static inline void l2_clean_pa_range(unsigned long start, unsigned long end)
> {
> unsigned long va_start, va_end, flags;
> @@ -96,11 +91,6 @@ static inline void l2_clean_inv_pa(unsigned long addr)
> __asm__("mcr p15, 1, %0, c15, c10, 3" : : "r" (addr));
> }
>
> -static inline void l2_inv_pa(unsigned long addr)
> -{
> - __asm__("mcr p15, 1, %0, c15, c11, 3" : : "r" (addr));
> -}
> -
> static inline void l2_inv_pa_range(unsigned long start, unsigned long end)
> {
> unsigned long va_start, va_end, flags;
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2015-01-05 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 17:56 [PATCH] arch: arm: mm: cache-feroceon-l2: Remove some unused functions Rickard Strandqvist
2015-01-05 14:32 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105143247.GD9142@lunn.ch \
--to=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox