From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034AbbAFIBc (ORCPT ); Tue, 6 Jan 2015 03:01:32 -0500 Received: from mail-lb0-f173.google.com ([209.85.217.173]:45208 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbbAFIBa (ORCPT ); Tue, 6 Jan 2015 03:01:30 -0500 Date: Tue, 6 Jan 2015 09:01:28 +0100 From: Johan Hovold To: "Peterson, David" Cc: "johan@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Added virtual com port VID/PID entries for CEL USB sticks and MeshWorks devices Signed-off-by: David Peterson Message-ID: <20150106080128.GA27633@localhost> References: <641A0889272F104D8B07278675C0C484010B1DC3@hq27> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <641A0889272F104D8B07278675C0C484010B1DC3@hq27> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ +CC: linux-usb] On Mon, Jan 05, 2015 at 08:46:52PM +0000, Peterson, David wrote: > From: David Peterson Almost there. Patch looks fine now, but the mail Subject (commit summary) is malformed (includes a sign-off tag). Care to resend with a subject like "USB: cp210x: add ids for CEL USB sticks and MeshWorks devices" It doesn't hurt including a commit message (e.g. your current Subject) between From: and Signed-off-by: in the body. > Signed-off-by: David Peterson > --- > drivers/usb/serial/cp210x.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 6c4eb3c..a6db2fc 100644 > --- a/drivers/usb/serial/cp210x.c > +++ b/drivers/usb/serial/cp210x.c > @@ -120,6 +120,9 @@ static const struct usb_device_id id_table[] = { > { USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */ > { USB_DEVICE(0x10C4, 0x8664) }, /* AC-Services CAN-IF */ > { USB_DEVICE(0x10C4, 0x8665) }, /* AC-Services OBD-IF */ > + { USB_DEVICE(0x10C4, 0x8856) }, /* CEL EM357 ZigBee USB Stick - LR */ > + { USB_DEVICE(0x10C4, 0x8857) }, /* CEL EM357 ZigBee USB Stick */ > + { USB_DEVICE(0x10C4, 0x8977) }, /* CEL MeshWorks DevKit Device */ > { USB_DEVICE(0x10C4, 0x8875) }, /* CEL MeshConnect USB Stick */ By the way, a recent patch changed this one to 0x8857. Is this indeed the same device as CEL EM357? http://marc.info/?l=linux-usb&m=141966558701806&w=2 > { USB_DEVICE(0x10C4, 0x88A4) }, /* MMB Networks ZigBee USB Device */ > { USB_DEVICE(0x10C4, 0x88A5) }, /* Planet Innovation Ingeni ZigBee USB Device */ Thanks, Johan