From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Konrad Zapalowicz <bergo.torino@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>, Piotr Kubus <p.t.kubus@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue
Date: Tue, 6 Jan 2015 19:20:25 +0530 [thread overview]
Message-ID: <20150106135025.GA17196@sudip-PC> (raw)
In-Reply-To: <20150106133327.GG25819@t400>
On Tue, Jan 06, 2015 at 02:33:27PM +0100, Konrad Zapalowicz wrote:
> On 01/06, Sudip Mukherjee wrote:
> > yes, i read the SubmittingPatches again. summary is the subject line. But then as Piotr Kubus has written that he could not find this rule in the documentaion, I also tried to find that in SubmittingPatches file and also in the Posting file of the development-process folder, but could not find it. Is it mentioned in some other file we missed ?
>
> Then it is an 'unwritten rule' :) You can observe it just be browsing
> the git log commit messages - pick a few random and you will see.
i don't need to veify it, I don't doubt the rule. if you see all the patches i have sent, i have always maintained a rule of 70.
just curious why this 72 ..
this one gives a reason why -
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
sudip
>
> Moreover in the http://git-scm.com/book/ch5-2.html the 72-character
> columns are the example of the good commit message plus Linus says so:
>
> "we use 72-character columns for word-wrapping, except for quoted
> material that has a specific line format."
>
> in one of his comments
> https://github.com/torvalds/linux/pull/17#issuecomment-5661185
>
> cheers,
> konrad
>
> > sudip
> > >
> > > --
> > > -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> > > -=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-01-06 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 15:22 [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue Piotr Kubus
2015-01-04 22:31 ` Konrad Zapalowicz
2015-01-05 19:24 ` Piotr Kubus
2015-01-06 6:02 ` Sudip Mukherjee
2015-01-06 10:08 ` Ian Abbott
2015-01-06 10:27 ` Sudip Mukherjee
2015-01-06 13:33 ` Konrad Zapalowicz
2015-01-06 13:50 ` Sudip Mukherjee [this message]
2015-01-06 10:06 ` Dan Carpenter
2015-01-10 0:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106135025.GA17196@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=bergo.torino@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.t.kubus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox