From: Mariusz Gorski <marius.gorski@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Evgeniy Polyakov <zbr@ioremap.net>, David Fries <David@Fries.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute
Date: Tue, 6 Jan 2015 21:19:07 +0100 [thread overview]
Message-ID: <20150106201906.GA4637@firebird> (raw)
In-Reply-To: <20150106174221.GA24538@kroah.com>
On Tue, Jan 06, 2015 at 09:42:21AM -0800, Greg Kroah-Hartman wrote:
> On Tue, Jan 06, 2015 at 03:29:56PM +0100, Mariusz Gorski wrote:
> > Add new attribute to simplify reading of current temperature.
> >
> > Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
> > ---
> > drivers/w1/slaves/w1_therm.c | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
>
> You add sysfs attributes without adding new Documentation/ABI/ entries,
> which means I can't take this patch series, sorry. Please redo it and
> add the needed information.
>
> Also, temperature should be a standard sensor attribute, so you might
> want to use that subsystem instead of creating your own ABI here.
Do you mean stuff described in Documentation/thermal/sysfs-api.txt? I am
not exactly sure which subsystem you mean.
> thanks,
>
> greg k-h
Thanks,
Mariusz
next prev parent reply other threads:[~2015-01-06 20:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 14:29 [PATCH 0/2] w1: slaves: w1_therm: Add sysfs entry for current temperature Mariusz Gorski
2015-01-06 14:29 ` [PATCH 1/2] w1: slaves: w1_therm: Extract read_rom function Mariusz Gorski
2015-01-06 14:29 ` [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute Mariusz Gorski
2015-01-06 17:42 ` Greg Kroah-Hartman
2015-01-06 20:19 ` Mariusz Gorski [this message]
2015-01-06 20:26 ` Greg Kroah-Hartman
2015-01-07 2:00 ` David Fries
2015-01-06 15:01 ` [PATCH 0/2] w1: slaves: w1_therm: Add sysfs entry for current temperature Richard Weinberger
2015-01-06 16:12 ` Mariusz Gorski
2015-01-06 16:50 ` Richard Weinberger
2015-01-07 2:27 ` David Fries
2015-01-07 1:59 ` David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106201906.GA4637@firebird \
--to=marius.gorski@gmail.com \
--cc=David@Fries.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox