From: Andrew Lunn <andrew@lunn.ch>
To: Ken Wilson <ken.wilson@opengear.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux@arm.linux.org.uk,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
gerg@uclinux.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, broonie@kernel.org,
ezequiel.garcia@free-electrons.com, galak@codeaurora.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: orion: Add multiple chip select support for Armada 370 and 375
Date: Tue, 6 Jan 2015 22:47:56 +0100 [thread overview]
Message-ID: <20150106214756.GE25030@lunn.ch> (raw)
In-Reply-To: <1420579846-31962-1-git-send-email-ken.wilson@opengear.com>
Hi Ken
> -static const struct orion_spi_dev armada_spi_dev_data = {
> +static const struct orion_spi_dev armada_370_spi_dev_data = {
> .typ = ARMADA_SPI,
> .min_divisor = 1,
> .max_divisor = 1920,
> .prescale_mask = ARMADA_SPI_CLK_PRESCALE_MASK,
> + .num_cs = 4,
> +};
> +
> +static const struct orion_spi_dev armada_375_spi_dev_data = {
> + .typ = ORION_SPI,
> + .min_divisor = 4,
> + .max_divisor = 30,
> + .prescale_mask = ORION_SPI_CLK_PRESCALE_MASK,
> + .num_cs = 3,
> };
Documentation/devicetree/bindings/spi/spi-bus.txt has the optional property:
- num-cs : total number of chipselects
Would it be better to use that?
Andrew
next prev parent reply other threads:[~2015-01-06 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 21:30 [PATCH] spi: orion: Add multiple chip select support for Armada 370 and 375 Ken Wilson
2015-01-06 21:37 ` Ezequiel Garcia
2015-01-06 21:47 ` Andrew Lunn [this message]
2015-01-06 22:00 ` Gregory CLEMENT
2015-01-07 6:41 ` Thomas Petazzoni
2015-01-07 8:08 ` Ken Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106214756.GE25030@lunn.ch \
--to=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=galak@codeaurora.org \
--cc=gerg@uclinux.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ken.wilson@opengear.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox