From: David Fries <David@Fries.net>
To: Mariusz Gorski <marius.gorski@gmail.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute
Date: Tue, 6 Jan 2015 20:00:03 -0600 [thread overview]
Message-ID: <20150107020003.GJ2522@spacedout.fries.net> (raw)
In-Reply-To: <1420554596-10250-3-git-send-email-marius.gorski@gmail.com>
On Tue, Jan 06, 2015 at 03:29:56PM +0100, Mariusz Gorski wrote:
> Add new attribute to simplify reading of current temperature.
> +static ssize_t temp_show(struct device *device,
> + struct device_attribute *attr, char *buf)
> +{
> + struct w1_slave *sl = dev_to_w1_slave(device);
> + struct w1_master *dev = sl->master;
> + u8 rom[9], verdict;
> + int temp;
> +
> + if (mutex_lock_interruptible(&dev->bus_mutex))
> + return -EINTR;
> +
> + memset(rom, 0, sizeof(rom));
> +
> + verdict = read_rom(device, rom);
> +
> + if (verdict < 0)
> + return verdict;
I wanted to point out that this returns without unlocking bus_mutex.
--
David Fries <david@fries.net> PGP pub CB1EE8F0
http://fries.net/~david/
next prev parent reply other threads:[~2015-01-07 2:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 14:29 [PATCH 0/2] w1: slaves: w1_therm: Add sysfs entry for current temperature Mariusz Gorski
2015-01-06 14:29 ` [PATCH 1/2] w1: slaves: w1_therm: Extract read_rom function Mariusz Gorski
2015-01-06 14:29 ` [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute Mariusz Gorski
2015-01-06 17:42 ` Greg Kroah-Hartman
2015-01-06 20:19 ` Mariusz Gorski
2015-01-06 20:26 ` Greg Kroah-Hartman
2015-01-07 2:00 ` David Fries [this message]
2015-01-06 15:01 ` [PATCH 0/2] w1: slaves: w1_therm: Add sysfs entry for current temperature Richard Weinberger
2015-01-06 16:12 ` Mariusz Gorski
2015-01-06 16:50 ` Richard Weinberger
2015-01-07 2:27 ` David Fries
2015-01-07 1:59 ` David Fries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107020003.GJ2522@spacedout.fries.net \
--to=david@fries.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.gorski@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox