From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756207AbbAGE0U (ORCPT ); Tue, 6 Jan 2015 23:26:20 -0500 Received: from mga14.intel.com ([192.55.52.115]:61893 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbbAGE0S (ORCPT ); Tue, 6 Jan 2015 23:26:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="508521228" Date: Wed, 7 Jan 2015 12:25:35 +0800 From: kbuild test robot To: Tejun Heo Cc: kbuild-all@01.org, Jens Axboe , Jan Kara , Andrew Morton , Linux Memory Management List , "Paul E. McKenney" , Maxim Patlasov , Johannes Weiner , Derek Basehore , linux-kernel@vger.kernel.org Subject: [PATCH] writeback: fix simple_return.cocci warnings Message-ID: <20150107042535.GA36032@athens> References: <201501071230.5cIaA8Xy%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201501071230.5cIaA8Xy%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu --- backing-dev.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write int bdi_init(struct backing_dev_info *bdi) { - int err; - bdi->dev = NULL; bdi->min_ratio = 0; @@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd INIT_LIST_HEAD(&bdi->bdi_list); INIT_LIST_HEAD(&bdi->work_list); - err = bdi_wb_init(&bdi->wb, bdi); - if (err) - return err; - - return 0; + return bdi_wb_init(&bdi->wb, bdi); } EXPORT_SYMBOL(bdi_init);