Re: [PATCH] writeback: fix simple_return.cocci warnings

Jan Kara
2015-01-07T08:41:33Z

On Wed 07-01-15 12:25:35, Wu Fengguang wrote:
> mm/backing-dev.c:513:1-4: WARNING: end returns can be simpified and declaration on line 502 can be dropped
>
> Simplify a trivial if-return sequence. Possibly combine with a
> preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Looks good.
Reviewed-by: Jan Kara <jack@suse.cz>

Honza
> ---
>
> backing-dev.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -499,8 +499,6 @@ static void bdi_wb_exit(struct bdi_write
>
> int bdi_init(struct backing_dev_info *bdi)
> {
> - int err;
> -
> bdi->dev = NULL;
>
> bdi->min_ratio = 0;
> @@ -510,11 +508,7 @@ int bdi_init(struct backing_dev_info *bd
> INIT_LIST_HEAD(&bdi->bdi_list);
> INIT_LIST_HEAD(&bdi->work_list);
>
> - err = bdi_wb_init(&bdi->wb, bdi);
> - if (err)
> - return err;
> -
> - return 0;
> + return bdi_wb_init(&bdi->wb, bdi);
> }
> EXPORT_SYMBOL(bdi_init);
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR