public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: simon <wei.guo.simon@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] STAGING: Fix pcl818.c coding style issue
Date: Wed, 7 Jan 2015 07:28:31 -0800	[thread overview]
Message-ID: <20150107152831.GB3338@kroah.com> (raw)
In-Reply-To: <20150107143924.GA2478@thunderCat>

On Wed, Jan 07, 2015 at 10:39:24PM +0800, simon wrote:
>  Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
> 
>  Correct coding style problem in pcl818.c

Why reverse the order here of things?

And what specific coding style issue(s) were fixed, you have to be
specific.

please fix up and resend.

thanks,

greg k-h

      reply	other threads:[~2015-01-07 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 14:39 [PATCH] STAGING: Fix pcl818.c coding style issue simon
2015-01-07 15:28 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107152831.GB3338@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wei.guo.simon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox