From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbbAGP2e (ORCPT ); Wed, 7 Jan 2015 10:28:34 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55415 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbbAGP2d (ORCPT ); Wed, 7 Jan 2015 10:28:33 -0500 Date: Wed, 7 Jan 2015 07:28:31 -0800 From: Greg Kroah-Hartman To: simon Cc: Ian Abbott , H Hartley Sweeten , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] STAGING: Fix pcl818.c coding style issue Message-ID: <20150107152831.GB3338@kroah.com> References: <20150107143924.GA2478@thunderCat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150107143924.GA2478@thunderCat> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 07, 2015 at 10:39:24PM +0800, simon wrote: > Signed-off-by: Simon Guo > > Correct coding style problem in pcl818.c Why reverse the order here of things? And what specific coding style issue(s) were fixed, you have to be specific. please fix up and resend. thanks, greg k-h