From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753710AbbAGSAi (ORCPT ); Wed, 7 Jan 2015 13:00:38 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:42669 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175AbbAGSAg convert rfc822-to-8bit (ORCPT ); Wed, 7 Jan 2015 13:00:36 -0500 Date: Wed, 7 Jan 2015 19:02:41 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: Andrew Jackson , Mark Brown , Dave Airlie , Jyri Sarha , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter Message-ID: <20150107190241.27ebac8b@armhf> In-Reply-To: <20150107154138.GL12302@n2100.arm.linux.org.uk> References: <23b36acc1f769418a06f3e929eba288b5911da12.1420628786.git.moinejf@free.fr> <54AD4C77.5000401@arm.com> <20150107154138.GL12302@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Jan 2015 15:41:38 +0000 Russell King - ARM Linux wrote: > On Wed, Jan 07, 2015 at 03:10:47PM +0000, Andrew Jackson wrote: > > On 01/07/15 10:51, Jean-Francois Moine wrote: > > > diff --git a/drivers/gpu/drm/i2c/Kconfig b/drivers/gpu/drm/i2c/Kconfig > > > index 22c7ed6..24fc975 100644 > > > --- a/drivers/gpu/drm/i2c/Kconfig > > > +++ b/drivers/gpu/drm/i2c/Kconfig > > > @@ -28,6 +28,7 @@ config DRM_I2C_SIL164 > > > config DRM_I2C_NXP_TDA998X > > > tristate "NXP Semiconductors TDA998X HDMI encoder" > > > default m if DRM_TILCDC > > > + select SND_SOC_TDA998X > > > > Do you need this since sound/soc/codecs/Kconfig conditionally brings in the > > CODEC driver? For SND_SOC_ALL_CODECS only. > More importantly, it's broken, because it'll cause Kconfig to complain > if you enable DRM_I2C_NXP_TDA998X, but have ASoC disabled. > > Moreover, if you decide you want the sound and ASoC built as a module, > but want to build in DRM and TDA998x support (so you can get video > output working on boot before initramfs/rootfs), Kconfig may well > complain. select SND_SOC_TDA998X if SND_SOC should work in all cases. > > > +static int __init tda998x_codec_init(void) > > > +{ > > > + return 0; > > > +} > > > +static void __exit tda998x_codec_exit(void) > > > +{ > > > +} > > > +module_init(tda998x_codec_init); > > > +module_exit(tda998x_codec_exit); > > There's no need for these if they remain as the above. Modules can have > both init/exit functions, or neither, and they are still unloadable. > Only modules which provide only an init function get locked in on load. Thanks. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/