From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Paul Walmsley <paul@pwsan.com>,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Paul Walmsley <pwalmsley@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Allen Martin <amartin@nvidia.com>,
Stephen Warren <swarren@nvidia.com>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH] soc: tegra: pmc: restrict compilation of suspend-related support to ARM
Date: Thu, 8 Jan 2015 09:49:31 +0100 [thread overview]
Message-ID: <20150108084929.GA1987@ulmo.nvidia.com> (raw)
In-Reply-To: <54AD4FB7.20600@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]
On Wed, Jan 07, 2015 at 06:24:39PM +0300, Dmitry Osipenko wrote:
> 07.01.2015 17:33, Thierry Reding пишет:
> > On Tue, Dec 09, 2014 at 10:36:50PM +0000, Paul Walmsley wrote:
> >>
> >> Tegra SoCs with 64-bit ARM support don't currently support deep CPU
> >> low-power states in mainline Linux. When this support is added in the
> >> future, it will probably look rather different from the existing
> >> 32-bit ARM support, since the ARM64 maintainers' strong preference is
> >> to use PSCI to implement it.
> >>
> >> So, for the time being, prevent the CPU suspend-related code and data
> >> in the Tegra PMC driver from compiling on ARM64.
> >>
> >> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> >> Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
> >> Cc: Thierry Reding <treding@nvidia.com>
> >> Cc: Allen Martin <amartin@nvidia.com>
> >> Cc: Stephen Warren <swarren@nvidia.com>
> >> Cc: Alexandre Courbot <gnurou@gmail.com>
> >> ---
> >> Applies on next-20141209.
> >> Intended for v3.20.
> >> Boot-tested on Tegra124 Jetson TK1 on next-20141209.
> >> Also boot-tested on Tegra132 Norrin FFD on next-20141209 + some unrelated
> >> patches.
> >>
> >> drivers/soc/tegra/pmc.c | 7 +++++--
> >> include/soc/tegra/pm.h | 2 +-
> >> 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > On second thought, I decided to apply this as-is.
> >
> > Thanks,
> > Thierry
> >
>
> Oh, I haven't noticed this patch before...
>
> I sent patch fixing tegra20 suspend bug [
> http://patchwork.ozlabs.org/patch/423778/ ] and it will obviously conflict with
> this one.
> For now there is no feedback for my suspend bug patch (other than for V1), but,
> if it's fine, I think it would be easier to rebase Paul's patch on top of it.
> Any other suggestions?
I don't like changing this back to syscore_ops since it makes things
less easier to follow. I also don't think that using PMC_SCRATCH41 for
two different purposes is a good thing. There are a couple of
suggestions in my reply to your original patch. Could you investigate
whether any of those can be used to fix this instead?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-08 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 22:36 [PATCH] soc: tegra: pmc: restrict compilation of suspend-related support to ARM Paul Walmsley
2014-12-10 11:23 ` Thierry Reding
2014-12-12 3:04 ` Paul Walmsley
2015-01-07 14:33 ` Thierry Reding
2015-01-07 15:24 ` Dmitry Osipenko
2015-01-07 15:55 ` Dmitry Osipenko
2015-01-08 8:49 ` Thierry Reding [this message]
2015-01-08 9:42 ` Dmitry Osipenko
2015-01-08 10:58 ` Thierry Reding
2015-01-08 11:23 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150108084929.GA1987@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=amartin@nvidia.com \
--cc=digetx@gmail.com \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=pwalmsley@nvidia.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).