public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tobias Klauser <tklauser@distanz.ch>
To: Aaron Wu <Aaron.wu@analog.com>
Cc: mkl@pengutronix.de, wg@grandegger.com, linux-can@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net
Subject: Re: [PATCH V2 2/2] bfin_can: rewrite the driver to support the common
Date: Thu, 8 Jan 2015 10:13:23 +0100	[thread overview]
Message-ID: <20150108091322.GE9157@distanz.ch> (raw)
In-Reply-To: <1420700254-22529-2-git-send-email-Aaron.wu@analog.com>

On 2015-01-08 at 07:57:34 +0100, Aaron Wu <Aaron.wu@analog.com> wrote:
> Rewrite the driver to comply to common style with MMU 
> 
> Signed-off-by: Aaron Wu <Aaron.wu@analog.com>
> ---
>  drivers/net/can/bfin_can.c |   21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/can/bfin_can.c b/drivers/net/can/bfin_can.c
> index 0a5eff4..1d116a7 100644
> --- a/drivers/net/can/bfin_can.c
> +++ b/drivers/net/can/bfin_can.c
[...]
> @@ -617,9 +615,6 @@ static int bfin_can_remove(struct platform_device *pdev)
>  
>  	unregister_candev(dev);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	release_mem_region(res->start, resource_size(res));
> -

struct resource *res will be unused in bfin_can_remove() after this
change, so it should be removed as well.

      parent reply	other threads:[~2015-01-08  9:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08  6:57 [PATCH V2 1/2] bfin_can: rewrite the blackfin style of read/write Aaron Wu
2015-01-08  6:57 ` [PATCH V2 2/2] bfin_can: rewrite the driver to support the common Aaron Wu
2015-01-08  8:59   ` Marc Kleine-Budde
2015-01-08  9:13   ` Tobias Klauser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150108091322.GE9157@distanz.ch \
    --to=tklauser@distanz.ch \
    --cc=Aaron.wu@analog.com \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox