* [PATCH] xfs: fix implicit bool to int conversion
@ 2015-01-08 12:49 Nicholas Mc Guire
2015-01-08 14:39 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-01-08 12:49 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs, linux-kernel, Nicholas Mc Guire
try_wait_for_completion returns bool so the wrapper function
xfs_dqflock_nowait should probably also return bool and not int.
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
patch was only compile tested x86_64_defconfig + CONFIG_XFS_FS=m
CONFIG_XFS_QUOTA=y
patch is against linux-next 3.19.0-rc3 -next-20150107
fs/xfs/xfs_dquot.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h
index c24c67e..2f536f3 100644
--- a/fs/xfs/xfs_dquot.h
+++ b/fs/xfs/xfs_dquot.h
@@ -86,7 +86,7 @@ static inline void xfs_dqflock(xfs_dquot_t *dqp)
wait_for_completion(&dqp->q_flush);
}
-static inline int xfs_dqflock_nowait(xfs_dquot_t *dqp)
+static inline bool xfs_dqflock_nowait(xfs_dquot_t *dqp)
{
return try_wait_for_completion(&dqp->q_flush);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: fix implicit bool to int conversion
2015-01-08 12:49 [PATCH] xfs: fix implicit bool to int conversion Nicholas Mc Guire
@ 2015-01-08 14:39 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2015-01-08 14:39 UTC (permalink / raw)
To: Nicholas Mc Guire; +Cc: Dave Chinner, linux-kernel, xfs
On Thu, Jan 08, 2015 at 01:49:51PM +0100, Nicholas Mc Guire wrote:
> try_wait_for_completion returns bool so the wrapper function
> xfs_dqflock_nowait should probably also return bool and not int.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
Indeed...
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> patch was only compile tested x86_64_defconfig + CONFIG_XFS_FS=m
> CONFIG_XFS_QUOTA=y
>
> patch is against linux-next 3.19.0-rc3 -next-20150107
>
> fs/xfs/xfs_dquot.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h
> index c24c67e..2f536f3 100644
> --- a/fs/xfs/xfs_dquot.h
> +++ b/fs/xfs/xfs_dquot.h
> @@ -86,7 +86,7 @@ static inline void xfs_dqflock(xfs_dquot_t *dqp)
> wait_for_completion(&dqp->q_flush);
> }
>
> -static inline int xfs_dqflock_nowait(xfs_dquot_t *dqp)
> +static inline bool xfs_dqflock_nowait(xfs_dquot_t *dqp)
> {
> return try_wait_for_completion(&dqp->q_flush);
> }
> --
> 1.7.10.4
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-08 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-08 12:49 [PATCH] xfs: fix implicit bool to int conversion Nicholas Mc Guire
2015-01-08 14:39 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox