From: Felipe Balbi <balbi@ti.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: <balbi@ti.com>, <linux-usb@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC] usb: dwc3: add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks
Date: Thu, 8 Jan 2015 11:08:15 -0600 [thread overview]
Message-ID: <20150108170815.GJ31926@saruman> (raw)
In-Reply-To: <20141208213551.38860f81@xhacker>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
Hi,
On Mon, Dec 08, 2014 at 09:35:51PM +0800, Jisheng Zhang wrote:
> On platforms which has native usb hosts/phys and pci-dwc3 controller,
> the dwc3 core may get the wrong usb2_phy and usb3_phy by
> devm_usb_get_phy(). It depends on which usb phy driver is initialized
> firstly, the usb_phy_generic or the native/real usb phy driver.
why are you initializing generic PHY if you have a real PHY ?
> Before all old USB phy library usage removed, the solution I can have
> is to add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks and set them
> in dwc3-pci.
> Could such modification can be accepted? If not, could you please give
> alternative suggestions?
we will not accept a quirk to skip PHYs, sorry. A better way of handling
this needs to be found.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-08 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 13:35 [RFC] usb: dwc3: add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks Jisheng Zhang
2015-01-08 17:08 ` Felipe Balbi [this message]
2015-01-09 6:24 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150108170815.GJ31926@saruman \
--to=balbi@ti.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox