[wsa:i2c/quirks 7/11] drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

[wsa:i2c/quirks 7/11] drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
head:   b1d39af8ae21f4930854b0656aa83a83fd38049e
commit: 70181ecd2990326a91edb3dac1db4cce21e561f7 [7/11] i2c: axxia: make use of the new infrastructure for quirks
reproduce:
  # apt-get install sparse
  git checkout 70181ecd2990326a91edb3dac1db4cce21e561f7
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH wsa] i2c: axxia: axxia_i2c_quirks can be static

[kbuild test robot]

drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 i2c-axxia.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-axxia.c b/drivers/i2c/busses/i2c-axxia.c
index 2d35476..488c5d3 100644
--- a/drivers/i2c/busses/i2c-axxia.c
+++ b/drivers/i2c/busses/i2c-axxia.c
@@ -449,7 +449,7 @@ static const struct i2c_algorithm axxia_i2c_algo = {
 	.functionality = axxia_i2c_func,
 };
 
-struct i2c_adapter_quirks axxia_i2c_quirks = {
+static struct i2c_adapter_quirks axxia_i2c_quirks = {
 	.max_read_len = 255,
 	.max_write_len = 255,
 };

Re: [wsa:i2c/quirks 7/11] drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Fri, Jan 09, 2015 at 01:57:37AM +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
> head:   b1d39af8ae21f4930854b0656aa83a83fd38049e
> commit: 70181ecd2990326a91edb3dac1db4cce21e561f7 [7/11] i2c: axxia: make use of the new infrastructure for quirks
> reproduce:
>   # apt-get install sparse
>   git checkout 70181ecd2990326a91edb3dac1db4cce21e561f7
>   make ARCH=x86_64 allmodconfig
>   make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.

Yes, it should be static.

However, this is a development branch and in this case it would be
enough if the test results would be directed to me only.

Is there a way to achieve this? I know that adding "experimental" to the
branch name will skip the testing. Is there another pattern to prevent
sending mails to everyone?

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [wsa:i2c/quirks 7/11] drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

[Fengguang Wu]

Hi Wolfram,

On Thu, Jan 08, 2015 at 07:28:48PM +0100, Wolfram Sang wrote:
> On Fri, Jan 09, 2015 at 01:57:37AM +0800, kbuild test robot wrote:
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
> > head:   b1d39af8ae21f4930854b0656aa83a83fd38049e
> > commit: 70181ecd2990326a91edb3dac1db4cce21e561f7 [7/11] i2c: axxia: make use of the new infrastructure for quirks
> > reproduce:
> >   # apt-get install sparse
> >   git checkout 70181ecd2990326a91edb3dac1db4cce21e561f7
> >   make ARCH=x86_64 allmodconfig
> >   make C=1 CF=-D__CHECK_ENDIAN__
> > 
> > 
> > sparse warnings: (new ones prefixed by >>)
> > 
> > >> drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?
> > 
> > Please review and possibly fold the followup patch.
> 
> Yes, it should be static.
> 
> However, this is a development branch and in this case it would be
> enough if the test results would be directed to me only.

It's normally private emails, except for the ones that carry patches
with them. In which case public mailing lists will also be CCed.

> Is there a way to achieve this? I know that adding "experimental" to the
> branch name will skip the testing. Is there another pattern to prevent
> sending mails to everyone?

I wonder if the occasional public emails are acceptable to you. If
not, it'd be trivial for me to add a list of "personal git trees"
where all emails including the auto generated patches will be kept
private (if commit author == committer).

Thanks,
Fengguang

Re: [wsa:i2c/quirks 7/11] drivers/i2c/busses/i2c-axxia.c:452:27: sparse: symbol 'axxia_i2c_quirks' was not declared. Should it be static?

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

Hi Fengguang,

> It's normally private emails, except for the ones that carry patches
> with them. In which case public mailing lists will also be CCed.

OK, thought so.

> > Is there a way to achieve this? I know that adding "experimental" to the
> > branch name will skip the testing. Is there another pattern to prevent
> > sending mails to everyone?
> 
> I wonder if the occasional public emails are acceptable to you.

Not really. If I push out development code which is good enough to be
build tested but not ready to be sent upstream yet, I think other people
and mailing lists should not be bothered.

> not, it'd be trivial for me to add a list of "personal git trees"
> where all emails including the auto generated patches will be kept
> private (if commit author == committer).

For my workflow, everything except "for-current" and "for-next" should
be private. I do appreciate the patches for those two, so thanks for
that in general!

All the best,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]