From: Peter Chen <peter.chen@freescale.com>
To: Daniel Tang <dt.tangr@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] Chipidea: Set connect-at-fullspeed bit when entering host mode if CI_HDRC_FORCE_FULLSPEED is set in the platform data
Date: Fri, 9 Jan 2015 09:38:19 +0800 [thread overview]
Message-ID: <20150109013817.GA433@shlinux2> (raw)
In-Reply-To: <1420337699-28219-2-git-send-email-dt.tangr@gmail.com>
On Sun, Jan 04, 2015 at 01:14:59PM +1100, Daniel Tang wrote:
> PORTSC_PFSC is not set on entering host mode which means the USB OTG
> controller will attempt to enumerate USB devices at high speed even when the
> CI_HDRC_FORCE_FULLSPEED flag is set in the platform data.
>
> This patch ensures it is set right before host mode operations begin if needed.
>
> Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
> ---
> drivers/usb/chipidea/host.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
> index c1694cf..f106d25 100644
> --- a/drivers/usb/chipidea/host.c
> +++ b/drivers/usb/chipidea/host.c
> @@ -132,6 +132,9 @@ static int host_start(struct ci_hdrc *ci)
> if (ci->platdata->flags & CI_HDRC_DISABLE_STREAMING)
> hw_write(ci, OP_USBMODE, USBMODE_CI_SDIS, USBMODE_CI_SDIS);
>
> + if (ci->platdata->flags & CI_HDRC_FORCE_FULLSPEED)
> + hw_write(ci, OP_PORTSC, PORTSC_PFSC, PORTSC_PFSC);
> +
> return ret;
>
> put_hcd:
> --
> 2.1.3
>
looks ok, will push
--
Best Regards,
Peter Chen
prev parent reply other threads:[~2015-01-09 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 2:14 [PATCH 1/2] Chipidea: TI-NSPIRE USB OTG hardware does not support high speed and must connect at full speed Daniel Tang
2015-01-04 2:14 ` [PATCH 2/2] Chipidea: Set connect-at-fullspeed bit when entering host mode if CI_HDRC_FORCE_FULLSPEED is set in the platform data Daniel Tang
2015-01-09 1:38 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109013817.GA433@shlinux2 \
--to=peter.chen@freescale.com \
--cc=dt.tangr@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox