From: Mark Rutland <mark.rutland@arm.com>
To: Stephen Wang <wstephen@codeaurora.org>
Cc: "jcliburn@gmail.com" <jcliburn@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ethernet: atheros: Add nss-gmac driver
Date: Fri, 9 Jan 2015 13:50:45 +0000 [thread overview]
Message-ID: <20150109135045.GE12942@leverpostej> (raw)
In-Reply-To: <1420754626-30121-1-git-send-email-wstephen@codeaurora.org>
On Thu, Jan 08, 2015 at 10:03:46PM +0000, Stephen Wang wrote:
> This driver adds support for the internal GMACs on IPQ806x SoCs.
> It supports the device-tree and will register up to 4 ethernet
> interfaces.
>
> Signed-off-by: Stephen Wang <wstephen@codeaurora.org>
> ---
> drivers/net/ethernet/atheros/Kconfig | 10 +
> drivers/net/ethernet/atheros/Makefile | 1 +
> drivers/net/ethernet/atheros/nss-gmac/LICENSE.txt | 14 +
> drivers/net/ethernet/atheros/nss-gmac/Makefile | 19 +
> .../atheros/nss-gmac/exports/nss_gmac_api_if.h | 126 ++
> .../atheros/nss-gmac/include/msm_nss_gmac.h | 338 ++++
> .../atheros/nss-gmac/include/msm_nss_macsec.h | 73 +
> .../atheros/nss-gmac/include/nss_gmac_clocks.h | 100 +
> .../atheros/nss-gmac/include/nss_gmac_dev.h | 2136 ++++++++++++++++++++
> .../nss-gmac/include/nss_gmac_network_interface.h | 63 +
> .../net/ethernet/atheros/nss-gmac/nss_gmac_ctrl.c | 1210 +++++++++++
> .../net/ethernet/atheros/nss-gmac/nss_gmac_dev.c | 1963 ++++++++++++++++++
> .../ethernet/atheros/nss-gmac/nss_gmac_ethtool.c | 526 +++++
> .../net/ethernet/atheros/nss-gmac/nss_gmac_init.c | 1131 +++++++++++
> .../ethernet/atheros/nss-gmac/nss_gmac_mdiobus.c | 187 ++
> .../atheros/nss-gmac/nss_gmac_tx_rx_offload.c | 1175 +++++++++++
Device tree bindings _must_ be documented, yet this standalone patch
adds nothing to Documentation/devicetree/bindings per the diffstat
above. So trivial NAK until there's a patch documenting that.
See Documentation/devicetree/bindings/submitting-patches.txt
Thanks,
Mark.
next prev parent reply other threads:[~2015-01-09 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 22:03 [PATCH] ethernet: atheros: Add nss-gmac driver Stephen Wang
2015-01-08 22:18 ` Joe Perches
2015-01-08 23:35 ` Arnd Bergmann
2015-01-15 8:12 ` wstephen
2015-01-15 12:34 ` Arnd Bergmann
2015-01-19 21:58 ` wstephen
2015-01-20 14:05 ` Arnd Bergmann
2015-01-22 0:20 ` wstephen
2015-01-22 10:18 ` Arnd Bergmann
2015-01-23 8:54 ` David Miller
2015-01-09 0:00 ` Francois Romieu
2015-01-09 13:50 ` Mark Rutland [this message]
2015-01-16 1:56 ` Stephen Hemminger
2015-01-16 1:58 ` Stephen Hemminger
2015-01-16 2:00 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109135045.GE12942@leverpostej \
--to=mark.rutland@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jcliburn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wstephen@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox