public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Simon Guo <wei.guo.simon@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3.19.0-rc3 1/1] STAGING: Fix pcl818.c coding style issue
Date: Fri, 9 Jan 2015 17:49:15 -0800	[thread overview]
Message-ID: <20150110014915.GA19362@kroah.com> (raw)
In-Reply-To: <20150109042003.GA3970@thunderCat>

On Fri, Jan 09, 2015 at 12:20:04PM +0800, Simon Guo wrote:
> Correct coding style problem in pcl818.c. The coding style problems(29 
> warnings detected by checkpatch.pl) includes:
> - line over 80 characters
> - There is space before tabs
> The changed file has been verified with checkpatch.pl to be clean for 
> warnings/errors.

Those are different things, so there should be different patches, make
this a series please.

Also fix up your trailing whitespace in the changelog itself.

thanks,

greg k-h

  reply	other threads:[~2015-01-10  1:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09  4:20 [PATCH 3.19.0-rc3 1/1] STAGING: Fix pcl818.c coding style issue Simon Guo
2015-01-10  1:49 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-01-08 10:07 simon
2015-01-08 14:01 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150110014915.GA19362@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wei.guo.simon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox