Re: [PATCH 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0

Namhyung Kim
2015-01-10T10:45:11Z

On Sat, Jan 10, 2015 at 10:16:06AM +0000, Vineet Gupta wrote:
> On Thursday 08 January 2015 01:23 PM, Namhyung Kim wrote:
> > Hmm.. okay. I think we don't need to allocate the id arrays when size
> > is 0. So perf_event__process_attr() will have the same problem IMHO.
> > How about this?
> >
> >
> > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> > index 1e90c8557ede..1d826d63bc20 100644
> > --- a/tools/perf/util/evsel.c
> > +++ b/tools/perf/util/evsel.c
> > @@ -797,6 +797,9 @@ int perf_evsel__enable(struct perf_evsel *evsel, int ncpus, int nthreads)
> >
> > int perf_evsel__alloc_id(struct perf_evsel *evsel, int ncpus, int nthreads)
> > {
> > + if (ncpus == 0 || nthreads == 0)
> > + return 0;
> > +
> > if (evsel->system_wide)
> > nthreads = 1;
>
> Fine by me as I'm not too familiar with perf tools internals.
> So I need to spin a v2 for this or would you rather create a patch with me as
> Reported-by:

Please include this in your v2 and adds me as Suggested-by:

Thanks,
Namhyung