Re: [PATCH 5/5] perf tools: [uclibc] provide stub for pthread_attr_setaffinity_np

Vineet Gupta
2015-01-10T10:31:04Z

Hi Namhyung,

On Thursday 08 January 2015 01:28 PM, Namhyung Kim wrote:
> On Tue, Jan 06, 2015 at 07:22:15PM +0530, Vineet Gupta wrote:
>> > uClibc Linuxthreads.old doesnt support pthread_attr_setaffinity_np()
>> > call
>> >
>> > ----------------->8-----------------------
>> > CC bench/futex-hash.o
>> > CC bench/futex-wake.o
>> > bench/futex-hash.c: In function 'bench_futex_hash':
>> > bench/futex-hash.c:161:3: error: implicit declaration of function
>> > 'pthread_attr_setaffinity_np' [-Werror=implicit-function-declaration]
>> > ret = pthread_attr_setaffinity_np(&thread_attr, sizeof(cpu_set_t),
>> > &cpu);
>> > ^
>> > bench/futex-hash.c:161:3: error: nested extern declaration of
>> > 'pthread_attr_setaffinity_np' [-Werror=nested-externs]
>> > ----------------->8-----------------------
>> >
>> > Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>> > ---
>> > tools/perf/bench/futex.h | 13 +++++++++++++
>> > tools/perf/config/Makefile | 6 ++++++
>> > tools/perf/config/feature-checks/Makefile | 4 ++++
>> > tools/perf/config/feature-checks/test-all.c | 5 +++++
>> > 4 files changed, 28 insertions(+)
> It seems that you fotgot to add the real test file
> (test-pthread_attr_setaffinity_np.c?) here..

Indeed, apologies for the snafu. I'll include it in v2 for the series.
Any thoughts on rest of patches for the series.
Thanks for the careful review so far.

-Vineet

>
> Thanks,
> Namhyung
>
>