From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753942AbbAJPLX (ORCPT ); Sat, 10 Jan 2015 10:11:23 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49386 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbbAJPLV (ORCPT ); Sat, 10 Jan 2015 10:11:21 -0500 Date: Sat, 10 Jan 2015 16:11:18 +0100 From: Pavel Machek To: Pantelis Antoniou Cc: atull , Greg Kroah-Hartman , jgunthorpe@obsidianresearch.com, hpa@zytor.com, Michal Simek , Michal Simek , rdunlap@infradead.org, Linux Kernel Mailing List , devicetree@vger.kernel.org, robh+dt@kernel.org, Grant Likely , iws@ovro.caltech.edu, linux-doc@vger.kernel.org, Mark Brown , philip@balister.org, rubini@gnudd.com, Steffen Trumtrar , jason@lakedaemon.net, kyle.teske@ni.com, nico@linaro.org, Felipe Balbi , m.chehab@samsung.com, davidb@codeaurora.org, Rob Landley , davem@davemloft.net, cesarb@cesarb.net, sameo@linux.intel.com, akpm@linux-foundation.org, Linus Walleij , pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devel@driverdev.osuosl.org, Alan Tull , dinguyen@opensource.altera.com, yvanderv@opensource.altera.com Subject: Re: [PATCH v8 2/4] fpga manager: add sysfs interface document Message-ID: <20150110151118.GA16036@amd> References: <1420575219-27061-1-git-send-email-atull@opensource.altera.com> <1420575219-27061-3-git-send-email-atull@opensource.altera.com> <20150107084819.GA1887@amd> <20150109205643.GA5761@amd> <4D4EA2D5-68DD-49F7-9E2D-3A0A8F6AF9CA@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4D4EA2D5-68DD-49F7-9E2D-3A0A8F6AF9CA@konsulko.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 2015-01-10 10:10:51, Pantelis Antoniou wrote: > Hi Pavel, > > > On Jan 9, 2015, at 22:56 , Pavel Machek wrote: > > > > On Fri 2015-01-09 13:14:24, atull wrote: > >> On Wed, 7 Jan 2015, Pavel Machek wrote: > >> > >>> On Tue 2015-01-06 14:13:37, atull@opensource.altera.com wrote: > >>>> + > >>>> +What: /sys/class/fpga_manager//firmware > >>>> +Date: October 2014 > >>>> +KernelVersion: 3.18 > >>>> +Contact: Alan Tull > >>>> +Description: Name of the FPGA image file to load using firmware > >>>> class. > >>> > >>> This one is ugly: it unneccessarily passes firmware name through the > >>> kernel. Just make interface and code simpler by always passing > >>> "socfpga-fpga-image" or something like that. > >>> > >>> Thanks, > >>> Pavel > >> > >> Hi Pavel, > >> > >> It might be ugly. It's not unnecessary. Some uses of FPGAs involve > >> switching out the FPGA images dynamically under control of the userspace. > > > > Then configure udev to load right firmware for you, or ln -s > > image-i-want-now socfpga-fpga-image to select the one to read…? > > > > Who said that udev is going to be available in the kind of system this is going to end in? Noone. > Doing ln -s tricks to load a different image? Really? But if you don't have udev, you can do ln -s. It is better than open-coding symlink functionality into /sys/class/fpga_manager//firmware ... cause that's what this is. Actually, clean implementation of "firmware" would be symlink in sysfs; but I'd say that would be overdoing it. > I say the interface is fine as it is. I say it is not. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html