From: Johan Hovold <johan@kernel.org>
To: Jeremiah Mahler <jmmahler@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RESEND PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk
Date: Sun, 11 Jan 2015 12:36:18 +0100 [thread overview]
Message-ID: <20150111113618.GA23221@localhost> (raw)
In-Reply-To: <1420937073-20835-2-git-send-email-jmmahler@gmail.com>
On Sat, Jan 10, 2015 at 04:44:32PM -0800, Jeremiah Mahler wrote:
> If a USB serial device is unplugged while there is an active program
> using the device it will spam the logs with -EPROTO (71) messages as it
> attempts to retry.
Can you change this to "might spam", as which error message, and if it is
at all printed, depends on host controller and what (hub) devices are
used.
> Most serial usb drivers (metro-usb, pl2303, mos7840, ...) only output
> these messages for debugging. The generic driver treats these as
> errors.
>
> Change the default output for the generic serial driver from error to
> debug.
Please also correct the commit summary (Subject) so that it matches what
this revised patch now does (you silence all non-critical error
messages).
Fix this up and I'll take both patches.
Thanks,
Johan
next prev parent reply other threads:[~2015-01-11 11:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 23:29 [PATCH 0/2] usb: serial: handle -ENODEV and -EPROTO quietly Jeremiah Mahler
2014-12-11 23:29 ` [PATCH 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk Jeremiah Mahler
2014-12-11 23:29 ` [PATCH 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2014-12-16 11:49 ` Johan Hovold
2014-12-15 10:23 ` [PATCH 0/2] usb: serial: handle -ENODEV and -EPROTO quietly Johan Hovold
2014-12-15 12:53 ` Jeremiah Mahler
2014-12-15 16:38 ` Greg Kroah-Hartman
2014-12-16 7:10 ` Jeremiah Mahler
2014-12-16 11:46 ` Johan Hovold
2014-12-16 11:42 ` Johan Hovold
2014-12-20 9:11 ` [PATCH v2 " Jeremiah Mahler
2014-12-20 9:11 ` [PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk Jeremiah Mahler
2014-12-20 12:32 ` Sergei Shtylyov
2014-12-20 12:59 ` Jeremiah Mahler
2014-12-20 16:17 ` [PATCH v2b " Jeremiah Mahler
2014-12-20 9:11 ` [PATCH v2 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2015-01-11 0:44 ` [RESEND PATCH v2 0/2] usb: serial: handle -ENODEV and -EPROTO quietly Jeremiah Mahler
2015-01-11 0:44 ` [RESEND PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk Jeremiah Mahler
2015-01-11 11:36 ` Johan Hovold [this message]
2015-01-11 13:31 ` Jeremiah Mahler
2015-01-11 0:44 ` [RESEND PATCH v2 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2015-01-11 13:42 ` [PATCH v3 0/2] usb: serial: silence non-critical unplug read errors Jeremiah Mahler
2015-01-11 13:42 ` [PATCH v3 1/2] usb: serial: silence all non-critical " Jeremiah Mahler
2015-01-11 13:42 ` [PATCH v3 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2015-01-12 9:27 ` [PATCH v3 0/2] usb: serial: silence non-critical unplug read errors Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150111113618.GA23221@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).