From: Richard Cochran <richardcochran@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Jones <davej@codemonkey.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Prarit Bhargava <prarit@redhat.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 03/10] clocksource: Remove clocksource_max_deferment()
Date: Sun, 11 Jan 2015 12:47:25 +0100 [thread overview]
Message-ID: <20150111114724.GE4467@localhost.localdomain> (raw)
In-Reply-To: <1420850068-27828-4-git-send-email-john.stultz@linaro.org>
This series added:
+ /* Return 50% of the actual maximum, so we can detect bad values */
+ max_nsecs >>= 1;
and then...
On Fri, Jan 09, 2015 at 04:34:21PM -0800, John Stultz wrote:
> @@ -760,7 +746,8 @@ void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq)
> cs->maxadj = clocksource_max_adjustment(cs);
> }
>
> - cs->max_idle_ns = clocksource_max_deferment(cs);
> + cs->max_idle_ns = clocks_calc_max_nsecs(cs->mult, cs->shift,
> + cs->maxadj, cs->mask);
> }
> EXPORT_SYMBOL_GPL(__clocksource_updatefreq_scale);
>
> @@ -807,7 +794,8 @@ int clocksource_register(struct clocksource *cs)
> cs->name);
>
> /* calculate max idle time permitted for this clocksource */
> - cs->max_idle_ns = clocksource_max_deferment(cs);
> + cs->max_idle_ns = clocks_calc_max_nsecs(cs->mult, cs->shift,
> + cs->maxadj, cs->mask);
... the whole world's maximum idle time is artificially reduced by
half in order to catch some rare HW bug? Not a very green solution.
Thanks,
Richard
next prev parent reply other threads:[~2015-01-11 11:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 0:34 [PATCH 00/10][RFC] Increased clocksource validation and cleanups John Stultz
2015-01-10 0:34 ` [PATCH 01/10] clocksource: Simplify clocks_calc_max_nsecs logic John Stultz
2015-01-10 0:34 ` [PATCH 02/10] clocksource: Simplify logic around clocksource wrapping saftey margins John Stultz
2015-01-10 2:03 ` Stephen Boyd
2015-01-10 0:34 ` [PATCH 03/10] clocksource: Remove clocksource_max_deferment() John Stultz
2015-01-11 11:47 ` Richard Cochran [this message]
2015-01-12 18:36 ` John Stultz
2015-01-12 20:16 ` Richard Cochran
2015-01-10 0:34 ` [PATCH 04/10] clocksource: Add max_cycles to clocksource structure John Stultz
2015-01-10 2:06 ` Stephen Boyd
2015-01-10 0:34 ` [PATCH 05/10] time: Add debugging checks to warn if we see delays John Stultz
2015-01-10 0:34 ` [PATCH 06/10] time: Cap clocksource reads to the clocksource max_cycles value John Stultz
2015-01-11 12:41 ` Richard Cochran
2015-01-12 18:54 ` John Stultz
2015-01-12 19:02 ` Linus Torvalds
2015-01-12 20:37 ` Richard Cochran
2015-01-12 20:30 ` Richard Cochran
2015-01-12 20:49 ` Richard Cochran
2015-01-13 11:11 ` Peter Zijlstra
2015-01-13 21:33 ` John Stultz
2015-01-13 22:51 ` Linus Torvalds
2015-01-14 9:35 ` Peter Zijlstra
2015-01-22 20:55 ` John Stultz
2015-01-10 0:34 ` [PATCH 07/10] time: Try to catch clocksource delta underflows John Stultz
2015-01-10 0:34 ` [PATCH 08/10] clocksource: Mostly kill clocksource_register() John Stultz
2015-01-10 0:34 ` [PATCH 09/10] sparc: Convert to using clocksource_register_hz() John Stultz
2015-01-10 0:34 ` [PATCH 10/10] clocksource: Add some debug info about clocksources being registered John Stultz
2015-01-10 2:02 ` Stephen Boyd
2015-01-22 0:51 ` John Stultz
2015-01-22 12:27 ` Prarit Bhargava
2015-01-11 11:41 ` [PATCH 00/10][RFC] Increased clocksource validation and cleanups Richard Cochran
2015-01-12 18:22 ` John Stultz
2015-01-12 20:45 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150111114724.GE4467@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davej@codemonkey.org.uk \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).