From: Josh Triplett <josh@joshtriplett.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Jaroslav Kysela <perex@perex.cz>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Rashika Kheria <rashika.kheria@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions
Date: Sun, 11 Jan 2015 12:18:06 -0800 [thread overview]
Message-ID: <20150111201806.GA1074@thin> (raw)
In-Reply-To: <s5htwzx2txw.wl-tiwai@suse.de>
On Sun, Jan 11, 2015 at 04:55:23PM +0100, Takashi Iwai wrote:
> At Sun, 11 Jan 2015 16:43:02 +0100,
> Rickard Strandqvist wrote:
> >
> > Removes some functions that are not used anywhere:
> > lx_buffer_cancel() lx_buffer_free() lx_stream_sample_position()
> > lx_stream_state() lx_pipe_sample_count()
>
> We really shouldn't delete the code but keep somehow disabled for such
> a driver that has no hardware spec documents available. Since the
> source code is the only reference, the implemented code is the only
> information if we need to change / fix anything.
Easy enough to get it back out of version control if so.
- Josh Triplett
next prev parent reply other threads:[~2015-01-11 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 15:43 [PATCH] ALSA: lx6464es: lx_core: Remove some unused functions Rickard Strandqvist
2015-01-11 15:55 ` Takashi Iwai
2015-01-11 20:18 ` Josh Triplett [this message]
2015-01-11 20:32 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150111201806.GA1074@thin \
--to=josh@joshtriplett.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=perex@perex.cz \
--cc=rashika.kheria@gmail.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox