Re: [PATCH v2 3/8] watchdog: at91rm9200: use the regmap from mfd

Alexandre Belloni
2015-01-10T18:41:50Z

On 09/01/2015 at 16:39:21 -0800, Guenter Roeck wrote :
> On 01/09/2015 01:51 AM, Alexandre Belloni wrote:
> > /* ......................................................................... */
> >@@ -204,6 +201,7 @@ static struct miscdevice at91wdt_miscdev = {
> > static int at91wdt_probe(struct platform_device *pdev)
> > {
> > int res;
> >+ regmap_st = dev_get_drvdata(pdev->dev.parent);
> >
>
> Is it guaranteed that parent is never NULL, and that the parent's
> drvdata is always set ?
>

The only way to probe the driver left is to use platform_data. It is
done from the MFD driver. If you prefer, I can test for NULL here and
return.

> Also, it seems that regmap_st will be overwritten if the device
> is already open (see code below). That may not be a good idea.
>

I'm not sure what you meani, pdev->dev.parent and at91wdt_miscdev.parent
are not the same thing. I didn't touch the code below but I believe
there is no reason to pass in the probe twice and return -EBUSY.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering