From: "J. Bruce Fields" <bfields@fieldses.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockd: xdr: Remove unused function
Date: Mon, 12 Jan 2015 16:24:53 -0500 [thread overview]
Message-ID: <20150112212453.GA1940@fieldses.org> (raw)
In-Reply-To: <1420909362-31705-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, Jan 10, 2015 at 06:02:42PM +0100, Rickard Strandqvist wrote:
> Remove the function nlm_encode_fh() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
Huh. OK, thanks--applying.
--b.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> fs/lockd/xdr.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/fs/lockd/xdr.c b/fs/lockd/xdr.c
> index 9340e7e..5b651da 100644
> --- a/fs/lockd/xdr.c
> +++ b/fs/lockd/xdr.c
> @@ -95,14 +95,6 @@ nlm_decode_fh(__be32 *p, struct nfs_fh *f)
> return p + XDR_QUADLEN(NFS2_FHSIZE);
> }
>
> -static inline __be32 *
> -nlm_encode_fh(__be32 *p, struct nfs_fh *f)
> -{
> - *p++ = htonl(NFS2_FHSIZE);
> - memcpy(p, f->data, NFS2_FHSIZE);
> - return p + XDR_QUADLEN(NFS2_FHSIZE);
> -}
> -
> /*
> * Encode and decode owner handle
> */
> --
> 1.7.10.4
>
prev parent reply other threads:[~2015-01-12 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 17:02 [PATCH] lockd: xdr: Remove unused function Rickard Strandqvist
2015-01-12 21:24 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112212453.GA1940@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox