public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	"Nicolas Ferre" <nicolas.ferre@atmel.com>
Cc: "Boris Brezillon" <boris.brezillon@free-electrons.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Alexandre Belloni" <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH 6/6] ARM: at91: move at91rm9200_idle() to clk/at91/pmc.c
Date: Mon, 12 Jan 2015 14:57:33 -0800	[thread overview]
Message-ID: <20150112225733.20842.93026@quantum> (raw)
In-Reply-To: <1421097825-396-7-git-send-email-alexandre.belloni@free-electrons.com>

Quoting Alexandre Belloni (2015-01-12 13:23:45)
> Move at91rm9200_idle() along with at91sam9_idle() in clk/at91/pmc.c.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> Cc: Mike Turquette <mturquette@linaro.org>

Acked-by: Michael Turquette <mturquette@linaro.org>

> 
> Mike, Boris,
> I guess that one can go through the at91 tree unless you have any objections.
> 
>  arch/arm/mach-at91/at91rm9200.c | 9 ---------
>  arch/arm/mach-at91/generic.h    | 1 +
>  drivers/clk/at91/pmc.c          | 9 +++++++++
>  3 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c
> index fc7c26138037..3be1963f5c56 100644
> --- a/arch/arm/mach-at91/at91rm9200.c
> +++ b/arch/arm/mach-at91/at91rm9200.c
> @@ -21,14 +21,6 @@
>  #include "soc.h"
>  #include "generic.h"
>  
> -static void at91rm9200_idle(void)
> -{
> -       /*
> -        * Disable the processor clock.  The processor will be automatically
> -        * re-enabled by an interrupt or by a reset.
> -        */
> -       at91_pmc_write(AT91_PMC_SCDR, AT91_PMC_PCK);
> -}
>  
>  static void at91rm9200_restart(enum reboot_mode reboot_mode, const char *cmd)
>  {
> @@ -49,7 +41,6 @@ static void __init at91rm9200_initialize(void)
>         arm_pm_restart = at91rm9200_restart;
>  }
>  
> -
>  AT91_SOC_START(at91rm9200)
>         .init = at91rm9200_initialize,
>  AT91_SOC_END
> diff --git a/arch/arm/mach-at91/generic.h b/arch/arm/mach-at91/generic.h
> index 18d5547f11d5..c4aa21fb765f 100644
> --- a/arch/arm/mach-at91/generic.h
> +++ b/arch/arm/mach-at91/generic.h
> @@ -25,6 +25,7 @@ extern void __init at91_dt_initialize(void);
>  extern void at91rm9200_timer_init(void);
>  
>  /* idle */
> +extern void at91rm9200_idle(void);
>  extern void at91sam9_idle(void);
>  
>  /* Matrix */
> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
> index 386999b4f8eb..f07c8152e5cc 100644
> --- a/drivers/clk/at91/pmc.c
> +++ b/drivers/clk/at91/pmc.c
> @@ -27,6 +27,15 @@
>  void __iomem *at91_pmc_base;
>  EXPORT_SYMBOL_GPL(at91_pmc_base);
>  
> +void at91rm9200_idle(void)
> +{
> +       /*
> +        * Disable the processor clock.  The processor will be automatically
> +        * re-enabled by an interrupt or by a reset.
> +        */
> +       at91_pmc_write(AT91_PMC_SCDR, AT91_PMC_PCK);
> +}
> +
>  void at91sam9_idle(void)
>  {
>         at91_pmc_write(AT91_PMC_SCDR, AT91_PMC_PCK);
> -- 
> 2.1.0
> 

  reply	other threads:[~2015-01-12 22:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 21:23 [PATCH 0/6] AT91 cleanup for 3.20 #2 Alexandre Belloni
2015-01-12 21:23 ` [PATCH 1/6] ARM: at91: pm: rework cpu detection Alexandre Belloni
2015-01-14 19:14   ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-14 20:21     ` Boris Brezillon
2015-01-14 20:37       ` Jean-Christophe PLAGNIOL-VILLARD
2015-01-14 21:07         ` Alexandre Belloni
2015-01-14 22:12           ` Arnd Bergmann
2015-01-12 21:23 ` [PATCH 2/6] ARM: at91: pm: use the mmio-sram pool to access SRAM Alexandre Belloni
2015-01-15  8:53   ` Yang, Wenyou
2015-01-15  9:14     ` Alexandre Belloni
2015-01-12 21:23 ` [PATCH 3/6] ARM: at91: remove useless map_io Alexandre Belloni
2015-01-12 21:23 ` [PATCH 4/6] ARM: at91: sama5d4: remove useless call to at91_init_sram Alexandre Belloni
2015-01-12 21:23 ` [PATCH 5/6] ARM: at91: remove unused at91_init_sram Alexandre Belloni
2015-01-12 21:23 ` [PATCH 6/6] ARM: at91: move at91rm9200_idle() to clk/at91/pmc.c Alexandre Belloni
2015-01-12 22:57   ` Mike Turquette [this message]
2015-01-13  9:25   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112225733.20842.93026@quantum \
    --to=mturquette@linaro.org \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox