* [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
@ 2014-12-19 11:38 Qais Yousef
2015-01-13 11:42 ` Qais Yousef
0 siblings, 1 reply; 4+ messages in thread
From: Qais Yousef @ 2014-12-19 11:38 UTC (permalink / raw)
To: alsa-devel
Cc: Qais Yousef, Vinod Koul, Jaroslav Kysela, Takashi Iwai,
linux-kernel
Fixes the following compilation error:
include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
if (snd_BUG_ON(!stream))
snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
so include it.
Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org
---
include/sound/compress_driver.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h
index 396e8f73670a..1e2531058b7e 100644
--- a/include/sound/compress_driver.h
+++ b/include/sound/compress_driver.h
@@ -27,6 +27,7 @@
#include <linux/types.h>
#include <linux/sched.h>
+#include <sound/core.h>
#include <sound/compress_offload.h>
#include <sound/asound.h>
#include <sound/pcm.h>
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
2014-12-19 11:38 [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly Qais Yousef
@ 2015-01-13 11:42 ` Qais Yousef
2015-01-13 14:45 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Qais Yousef @ 2015-01-13 11:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Vinod Koul, Jaroslav Kysela, Takashi Iwai, linux-kernel
Ping
On 12/19/2014 11:38 AM, Qais Yousef wrote:
> Fixes the following compilation error:
>
> include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
> include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
> if (snd_BUG_ON(!stream))
>
> snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> so include it.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: linux-kernel@vger.kernel.org
>
> ---
> include/sound/compress_driver.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h
> index 396e8f73670a..1e2531058b7e 100644
> --- a/include/sound/compress_driver.h
> +++ b/include/sound/compress_driver.h
> @@ -27,6 +27,7 @@
>
> #include <linux/types.h>
> #include <linux/sched.h>
> +#include <sound/core.h>
> #include <sound/compress_offload.h>
> #include <sound/asound.h>
> #include <sound/pcm.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
2015-01-13 11:42 ` Qais Yousef
@ 2015-01-13 14:45 ` Vinod Koul
2015-01-13 16:22 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2015-01-13 14:45 UTC (permalink / raw)
To: Qais Yousef, Takashi Iwai; +Cc: alsa-devel, Jaroslav Kysela, linux-kernel
On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote:
> Ping
>
> On 12/19/2014 11:38 AM, Qais Yousef wrote:
> >Fixes the following compilation error:
> >
> > include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
> > include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
> > if (snd_BUG_ON(!stream))
> >
> >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> >so include it.
> >
> >Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> >Cc: Vinod Koul <vinod.koul@intel.com>
> >Cc: Jaroslav Kysela <perex@perex.cz>
> >Cc: Takashi Iwai <tiwai@suse.de>
> >Cc: linux-kernel@vger.kernel.org
> >
Looks okay to me
Acked-by: Vinod Koul <vinod.koul@intel.com>
Thanks
--
~Vinod
> >---
> > include/sound/compress_driver.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h
> >index 396e8f73670a..1e2531058b7e 100644
> >--- a/include/sound/compress_driver.h
> >+++ b/include/sound/compress_driver.h
> >@@ -27,6 +27,7 @@
> > #include <linux/types.h>
> > #include <linux/sched.h>
> >+#include <sound/core.h>
> > #include <sound/compress_offload.h>
> > #include <sound/asound.h>
> > #include <sound/pcm.h>
>
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
2015-01-13 14:45 ` Vinod Koul
@ 2015-01-13 16:22 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2015-01-13 16:22 UTC (permalink / raw)
To: Vinod Koul; +Cc: Qais Yousef, alsa-devel, Jaroslav Kysela, linux-kernel
At Tue, 13 Jan 2015 20:15:49 +0530,
Vinod Koul wrote:
>
> On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote:
> > Ping
> >
> > On 12/19/2014 11:38 AM, Qais Yousef wrote:
> > >Fixes the following compilation error:
> > >
> > > include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
> > > include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
> > > if (snd_BUG_ON(!stream))
> > >
> > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> > >so include it.
> > >
> > >Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> > >Cc: Vinod Koul <vinod.koul@intel.com>
> > >Cc: Jaroslav Kysela <perex@perex.cz>
> > >Cc: Takashi Iwai <tiwai@suse.de>
> > >Cc: linux-kernel@vger.kernel.org
> > >
> Looks okay to me
>
> Acked-by: Vinod Koul <vinod.koul@intel.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-13 16:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-19 11:38 [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly Qais Yousef
2015-01-13 11:42 ` Qais Yousef
2015-01-13 14:45 ` Vinod Koul
2015-01-13 16:22 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox