From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753852AbbAMSwD (ORCPT ); Tue, 13 Jan 2015 13:52:03 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49713 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753681AbbAMSwC (ORCPT ); Tue, 13 Jan 2015 13:52:02 -0500 Date: Tue, 13 Jan 2015 10:52:00 -0800 From: Greg Kroah-Hartman To: Krzysztof Adamski Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private members. Message-ID: <20150113185200.GA25686@kroah.com> References: <20141222161541.GA11764@box2.japko.eu> <20150113034212.GA16174@kroah.com> <20150113184227.GK30114@box2.japko.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150113184227.GK30114@box2.japko.eu> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 13, 2015 at 07:42:28PM +0100, Krzysztof Adamski wrote: > On Mon, Jan 12, 2015 at 07:42:12PM -0800, Greg Kroah-Hartman wrote: > >On Mon, Dec 22, 2014 at 05:15:41PM +0100, Krzysztof Adamski wrote: > >>This patch fixes checkpatch.pl warning: > >>WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet > >>addresses are __aligned(2) > >> > >>current_net_addr and permanent_net_addr members of vnt_private alignment > >>is changed to at last 16 bits so that ether_addr_copy can be safely used > >>on them. > >> > >>buf->data is of type ieee80211_cts which is already properly aligned. > >> > >>Signed-off-by: Krzysztof Adamski > >>--- > >>drivers/staging/vt6656/device.h | 4 ++-- > >>drivers/staging/vt6656/main_usb.c | 3 ++- > >>drivers/staging/vt6656/rxtx.c | 4 ++-- > >>3 files changed, 6 insertions(+), 5 deletions(-) > > > >Doesn't apply to my tree :( > > Strange, I was trying to apply this on your tree to fix any conflicts but > apparently you already has this patch in your staging-testing branch. And as > far as I can tell I only sent it once to you. I think you sent it lots of times, if it's there already, don't worry about it :) thanks, greg k-h