From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Wang, Jiada (ESD)" <Jiada_Wang@mentor.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Frkuska, Joshua" <Joshua_Frkuska@mentor.com>
Subject: Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash
Date: Tue, 13 Jan 2015 21:54:12 +0000 [thread overview]
Message-ID: <20150113215412.GS4160@sirena.org.uk> (raw)
In-Reply-To: <s5h1tmyiof7.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Tue, Jan 13, 2015 at 06:24:44PM +0100, Takashi Iwai wrote:
> Wang, Jiada (ESD) wrote:
> > I am using i.MX6Q sabreSD board, which have imx_wm892 machine driver, wm8962 codec and SSI CPU DAI,
> > I got Kernel crash when unloading audio drivers (playback stream is active)
> > modprobe -r snd_soc_imx_wm8962
> > modprobe -r snd_soc_fsl_ssi
> > modprobe -r snd_soc_wm8962
> The root problem is that you can unload the module while playing.
> The corresponding module refcounts should have been increased during
> used.
> Do we miss [try_]module_get() somewhere in ASoC?
That doesn't help, users can still forcibly unbind the driver at runtime
without loading the module - and there's always the potential for
actually hotpluggable hardware. The teardown paths should be able to
cope somewhat gracefully.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-13 21:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 11:39 unload Audio drivers while playback stream is active case kernel crash Wang, Jiada (ESD)
2015-01-13 17:24 ` [alsa-devel] " Takashi Iwai
2015-01-13 21:54 ` Mark Brown [this message]
2015-01-14 7:43 ` Takashi Iwai
2015-01-14 8:15 ` Lars-Peter Clausen
2015-01-14 8:25 ` jiwang
2015-01-14 9:34 ` Lars-Peter Clausen
2015-01-14 8:47 ` Takashi Iwai
2015-01-14 10:00 ` Lars-Peter Clausen
2015-01-14 10:50 ` Takashi Iwai
2015-01-14 12:02 ` Mark Brown
2015-01-14 12:57 ` Lars-Peter Clausen
2015-01-14 13:06 ` Takashi Iwai
2015-01-14 13:43 ` Fabio Estevam
2015-01-15 4:40 ` jiwang
2015-01-15 6:14 ` Takashi Iwai
2015-01-15 10:52 ` Mark Brown
2015-01-14 13:01 ` Takashi Iwai
2015-01-14 16:34 ` Mark Brown
2015-01-15 6:21 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113215412.GS4160@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Jiada_Wang@mentor.com \
--cc=Joshua_Frkuska@mentor.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox